From: Marcel Holtmann <marcel@holtmann.org>
To: ofono@ofono.org
Subject: Re: [RFC PATCH v1 2/2] huawei: fix online logic
Date: Fri, 17 Sep 2010 21:53:52 +0900 [thread overview]
Message-ID: <1284728032.2405.215.camel@localhost.localdomain> (raw)
In-Reply-To: <20100917102358.8517.8873.stgit@potku.valot.fi>
[-- Attachment #1: Type: text/plain, Size: 612 bytes --]
Hi Kalle,
> plugins/huawei.c | 79 ++++++++++++++++++++++++++++++++++++++----------------
> 1 files changed, 55 insertions(+), 24 deletions(-)
>
> diff --git a/plugins/huawei.c b/plugins/huawei.c
> index ad1c3ae..0b4e65e 100644
> --- a/plugins/huawei.c
> +++ b/plugins/huawei.c
> @@ -78,6 +78,7 @@ struct huawei_data {
> gboolean voice;
> guint query_sim_state;
> guint sim_poll_count;
> + struct cb_data *online_cbd;
> };
doing it like this make me suspisious that this is the right approach.
No other modem plugin has to do it this way. Why does Huawei?
Regards
Marcel
next prev parent reply other threads:[~2010-09-17 12:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-17 10:23 [RFC PATCH v1 0/2] huawei: fix cold start Kalle Valo
2010-09-17 10:23 ` [RFC PATCH v1 1/2] huawei: poll sim state Kalle Valo
2010-09-17 12:48 ` Marcel Holtmann
2010-09-20 12:29 ` Kalle Valo
2010-09-17 10:23 ` [RFC PATCH v1 2/2] huawei: fix online logic Kalle Valo
2010-09-17 12:53 ` Marcel Holtmann [this message]
2010-09-17 13:58 ` Kalle Valo
2010-09-17 14:16 ` Kalle Valo
2010-09-17 13:07 ` [RFC PATCH v1 0/2] huawei: fix cold start Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1284728032.2405.215.camel@localhost.localdomain \
--to=marcel@holtmann.org \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox