Open Source Telephony
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: ofono@ofono.org
Subject: Re: [PATCH] isimodem/voicecall: fix hangup_active
Date: Wed, 06 Oct 2010 11:34:05 +0200	[thread overview]
Message-ID: <1286357645.6145.27.camel@aeonflux> (raw)
In-Reply-To: <1286356981-29522-1-git-send-email-Pekka.Pessi@nokia.com>

[-- Attachment #1: Type: text/plain, Size: 993 bytes --]

Hi Pekka,

> ---
>  drivers/isimodem/voicecall.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/isimodem/voicecall.c b/drivers/isimodem/voicecall.c
> index 4b720be..ace2346 100644
> --- a/drivers/isimodem/voicecall.c
> +++ b/drivers/isimodem/voicecall.c
> @@ -988,11 +988,11 @@ static void isi_answer(struct ofono_voicecall *ovc,
>  	isi_call_answer_req(ovc, CALL_ID_ALL, cb, data);
>  }
>  
> -static void isi_hangup(struct ofono_voicecall *ovc,
> +static void isi_hangup_active(struct ofono_voicecall *ovc,
>  			ofono_voicecall_cb_t cb, void *data)
>  {
>  	/* AT+CHUP */
> -	isi_call_release_req(ovc, CALL_ID_ALL, CALL_CAUSE_TYPE_CLIENT,
> +	isi_call_release_req(ovc, CALL_ID_ACTIVE, CALL_CAUSE_TYPE_CLIENT,
>  				CALL_CAUSE_RELEASE_BY_USER, cb, data);

while at it, you might also wanna remove the reference to an AT command.
Seems like a copy&past leftover from the original atmodem driver.

Regards

Marcel



  reply	other threads:[~2010-10-06  9:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-06  9:23 [PATCH] isimodem/voicecall: fix hangup_active Pekka.Pessi
2010-10-06  9:34 ` Marcel Holtmann [this message]
2010-10-06  9:56   ` Pekka Pessi
2010-10-06  9:58 ` [PATCH-v2] " Pekka.Pessi
2010-10-06 10:08   ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1286357645.6145.27.camel@aeonflux \
    --to=marcel@holtmann.org \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox