Open Source Telephony
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: ofono@ofono.org
Subject: Re: [PATCH] atmodem: Remove at_pin_send_puk_cb, and use at_pin_send_cb instead.
Date: Wed, 03 Nov 2010 14:37:46 +0100	[thread overview]
Message-ID: <1288791466.9615.46.camel@aeonflux> (raw)
In-Reply-To: <1288785996-10991-1-git-send-email-maritsofie.henriksen8@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 499 bytes --]

Hi Marit,

> When adding the use of pin event *EPEV also to at_pin_send_puk_cb,
> it becomes identical to at_pin_send_cb, and can be removed.
> ---
>  drivers/atmodem/sim.c |   44 +-------------------------------------------
>  1 files changed, 1 insertions(+), 43 deletions(-)

I am fine with this patch, but I have let Denis have a second look.
Since getting this right for IFX took me three attempts. Most likely
that was my own stupidity, but just in case ;)

Regards

Marcel



  reply	other threads:[~2010-11-03 13:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-03 12:06 [PATCH] atmodem: Remove at_pin_send_puk_cb, and use at_pin_send_cb instead Marit Henriksen
2010-11-03 13:37 ` Marcel Holtmann [this message]
2010-11-03 13:44 ` Denis Kenzior
  -- strict thread matches above, loose matches on Subject: below --
2010-11-03 14:35 Marit Henriksen
2010-11-03 14:40 ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1288791466.9615.46.camel@aeonflux \
    --to=marcel@holtmann.org \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox