Re: [PATCH] sim: Check SIM pin status after changing pin.

[Marcel Holtmann <marcel@holtmann.org>]

[-- Attachment #1: Type: text/plain, Size: 1206 bytes --]

Hi Marit,

as Denis mentioned and I stated many times, please don't top post on
this mailing list. It is against our mailing list etiquette.

> OK, I can see that this approach was rather too simplistic... Maybe checking
> the returned CME error would be a better idea?
> I’m a bit unsure how (or if) to proceed with this. As this is in the core,
> and not our driver, it might be more on your table? If you think it is
> important.

So if I follow this logic, then it does mean we should not be fixing
issues with the STE driver anymore? And not allowing you to use the
generic AT modem and generic MBM modem drivers? Since these are strictly
speaking not STE driver either.

This is not how this works. Everybody works for the greater good to
improve oFono. This is the way how it makes progress. The core is not a
fixed piece of software. It evolves with the modems we support. If it
needs to be changed or improved, then that is a task you should take up.

And as explained by Denis, if you have found such a problem area inside
the core, the generic drivers or anywhere else, write it down as part of
the TODO list. So patches are highly encouraged.

Regards

Marcel