From: Sjur =?unknown-8bit?q?Br=C3=A6ndeland?= <sjurbren@gmail.com>
To: ofono@ofono.org
Subject: [PATCH] coding-style: Add exception to M12 rule for external enums
Date: Wed, 17 Nov 2010 08:09:12 +0100 [thread overview]
Message-ID: <1289977754-7530-1-git-send-email-sjurbren@gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 656 bytes --]
From: Sjur Brændeland <sjur.brandeland@stericsson.com>
---
doc/coding-style.txt | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/doc/coding-style.txt b/doc/coding-style.txt
index 6fa355e..fb43891 100644
--- a/doc/coding-style.txt
+++ b/doc/coding-style.txt
@@ -205,6 +205,10 @@ default: // wrong
break;
}
+However if the enum comes from an external header file outside ofono
+we cannot make any assumption of how the enum is defined and this
+rule might not apply.
+
O1: Shorten the name
====================
Better to use abbreviation, rather than full name, to name a variable,
--
1.7.0.4
next reply other threads:[~2010-11-17 7:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-17 7:09 Sjur =?unknown-8bit?q?Br=C3=A6ndeland?= [this message]
2010-11-17 7:09 ` [PATCH] todo: Add Location Service (AGPS) task Sjur =?unknown-8bit?q?Br=C3=A6ndeland?=
2010-11-17 14:29 ` Denis Kenzior
2010-11-17 7:09 ` [PATCH] stemodem: Change use of types Sjur =?unknown-8bit?q?Br=C3=A6ndeland?=
2010-11-17 14:28 ` [PATCH] coding-style: Add exception to M12 rule for external enums Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1289977754-7530-1-git-send-email-sjurbren@gmail.com \
--to=sjurbren@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox