From: Marcel Holtmann <marcel@holtmann.org>
To: ofono@ofono.org
Subject: Re: [PATCH 2/3] Use %m instead of strerror() in syslog messages
Date: Thu, 25 Nov 2010 13:12:20 +0100 [thread overview]
Message-ID: <1290687140.4795.2.camel@aeonflux> (raw)
In-Reply-To: <1290682265-11373-2-git-send-email-remi.denis-courmont@nokia.com>
[-- Attachment #1: Type: text/plain, Size: 458 bytes --]
Hi Remi,
> strerror() is not thread-safe, nor in the glibc implementation,
> nor in the POSIX specification. In my experience, it will infrequently
> crash when another thread uses locale data in any way, including
> string formatting and such...
I have no problem with this ...
> Since the Huawei driver uses thread, we might as well avoid strerror().
..., but what are you talking about? Where is it using threads?
Regards
Marcel
next prev parent reply other threads:[~2010-11-25 12:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-25 10:51 [PATCH 1/3] Remove stray newlines in DBG and ofono log messages =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont
2010-11-25 10:51 ` [PATCH 2/3] Use %m instead of strerror() in syslog messages =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont
2010-11-25 12:12 ` Marcel Holtmann [this message]
2010-11-25 13:28 ` =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont
2010-11-26 21:12 ` Denis Kenzior
2010-11-29 8:11 ` =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont
2010-11-29 9:28 ` Marcel Holtmann
2010-11-25 10:51 ` [PATCH 3/3] gisi: use strerror_r() instead of strerror() =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont
2010-11-26 21:07 ` Denis Kenzior
2010-11-29 8:09 ` =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont
2010-11-26 19:51 ` [PATCH 1/3] Remove stray newlines in DBG and ofono log messages Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1290687140.4795.2.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox