From: Marit Henriksen <maritsofie.henriksen8@gmail.com>
To: ofono@ofono.org
Subject: [PATCH] stemodem: Fix for MT call not working when caller id is hidden.
Date: Thu, 16 Dec 2010 14:56:31 +0100 [thread overview]
Message-ID: <1292507791-23495-1-git-send-email-maritsofie.henriksen8@gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1043 bytes --]
From: Marit Henriksen <marit.henriksen@stericsson.com>
In *ECAV, the number will not be included if caller id is hidden.
Set it to an empty string in that case.
---
drivers/stemodem/voicecall.c | 10 +++++++---
1 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/stemodem/voicecall.c b/drivers/stemodem/voicecall.c
index b9d91d2..d900666 100644
--- a/drivers/stemodem/voicecall.c
+++ b/drivers/stemodem/voicecall.c
@@ -442,10 +442,14 @@ static void ecav_notify(GAtResult *result, gpointer user_data)
if (status == CALL_STATUS_DIALING ||
status == CALL_STATUS_WAITING ||
status == CALL_STATUS_INCOMING) {
+ /*
+ * If caller uses hidden id, the number and
+ * number type might not be present. Don't
+ * look for type if number is not present.
+ */
if (!g_at_result_iter_next_string(&iter, &num))
- return;
-
- if (!g_at_result_iter_next_number(&iter, &num_type))
+ num = "";
+ else if (!g_at_result_iter_next_number(&iter, &num_type))
return;
}
--
1.7.1
next reply other threads:[~2010-12-16 13:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-16 13:56 Marit Henriksen [this message]
2010-12-17 16:09 ` [PATCH] stemodem: Fix for MT call not working when caller id is hidden Denis Kenzior
2010-12-20 12:59 ` Marit Sofie Henriksen
2010-12-20 15:24 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1292507791-23495-1-git-send-email-maritsofie.henriksen8@gmail.com \
--to=maritsofie.henriksen8@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox