From: Marcel Holtmann <marcel@holtmann.org>
To: ofono@ofono.org
Subject: Re: [PATCH v2 8/9] udev: Add cdmagen
Date: Sat, 18 Dec 2010 19:29:27 +0100 [thread overview]
Message-ID: <1292696967.2658.12.camel@aeonflux> (raw)
In-Reply-To: <1292627481-9109-9-git-send-email-dara.spieker-doyle@nokia.com>
[-- Attachment #1: Type: text/plain, Size: 571 bytes --]
Hi Dara,
> struct ofono_modem *modem;
> @@ -533,6 +552,8 @@ done:
> add_isi(modem, udev_device);
> else if (g_strcmp0(driver, "n900") == 0)
> add_isi(modem, udev_device);
> + else if (g_strcmp0(driver, "cdmagen") == 0)
> + add_cdmagen(modem, udev_device);
> }
this is actually wrong. The generic drivers running against phonesim
should not be done via udev. We did remove atgen for a reason actually
since it was not really useful.
Even the isigen driver needs to be renamed into isiusb or usbpn in the
long term.
Regards
Marcel
next prev parent reply other threads:[~2010-12-18 18:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-17 23:11 [PATCH v2 8/9] udev: Add cdmagen Dara Spieker-Doyle
2010-12-18 18:29 ` Marcel Holtmann [this message]
2010-12-20 18:31 ` Dara Spieker-Doyle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1292696967.2658.12.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox