From: Marcel Holtmann <marcel@holtmann.org>
To: ofono@ofono.org
Subject: Re: [RFC PATCH 0/4] Atom for Neighbour Cell Info
Date: Tue, 21 Dec 2010 06:04:46 -0800 [thread overview]
Message-ID: <1292940286.2658.18.camel@aeonflux> (raw)
In-Reply-To: <1292940024-24363-1-git-send-email-antti.paila@nokia.com>
[-- Attachment #1: Type: text/plain, Size: 602 bytes --]
Hi Antti,
> This series of patches implements an interface for client
> application to fetch the ECID information of neighbouring
> cells using DBUS.
>
> src/cell-info.c | 537 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
> include/cell-info.h | 66 +++++++++++++++++++++++++++++++++++++++++++++++++++
> include/dbus.h | 1 +
> src/ofono.h | 1 +
> Makefile.am | 4 ++--
I am missing the D-Bus API documentation in this patch. I know that
proposals have been posted, but you need to pick that up and make it
part of your patchset.
Regards
Marcel
prev parent reply other threads:[~2010-12-21 14:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-21 14:00 [RFC PATCH 0/4] Atom for Neighbour Cell Info Antti Paila
2010-12-21 14:00 ` [RFC PATCH 1/4] cell-info: Atom for ECID info of neighb cells Antti Paila
2010-12-21 14:00 ` [RFC PATCH 2/4] cell-info: Header file for cell-info atom Antti Paila
2010-12-21 18:32 ` Bastian, Waldo
2010-12-21 14:00 ` [RFC PATCH 3/4] cell-info: Interface declarations Antti Paila
2010-12-21 14:00 ` [RFC PATCH 4/4] cell-info: New files included for compilation Antti Paila
2010-12-21 14:04 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1292940286.2658.18.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox