Open Source Telephony
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: ofono@ofono.org
Subject: Re: [PATCH 0/4 v2] Network Time plugin
Date: Tue, 21 Dec 2010 06:17:44 -0800	[thread overview]
Message-ID: <1292941064.2658.29.camel@aeonflux> (raw)
In-Reply-To: <1292916842.10058.5.camel@apaila-ThinkPad-T410>

[-- Attachment #1: Type: text/plain, Size: 989 bytes --]

Hi Antti,

please do not top-post on this mailing list.

> Could someone review this patch. It has been waiting for review a while
> now. Thanks.

<snip>

> > This series of patches introduces the network time part of the NITZ feature 
> >  as outlined in 3GPP spec 22.042. The Network Time plugin has two DBUS 
> >  interfaces for client applications: notification signal and polling method 
> >  call. The time information consists of three dictionary entries: 1) time and 
> >  date in seconds from epoch (renormalized to time indicatation arrival time);
> >  2) daylight saving time; 3) timezone.

I am still saying that the plugin should monitor the presence of timed
and then just send a D-Bus message to timed. That saves us the problem
with the timestamping. And in case timed is not running it should just
set the current time directly.

I really prefer that we don't hand out timestamps over the D-Bus API.
That seems wrong to me.

Regards

Marcel



  reply	other threads:[~2010-12-21 14:17 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-10  7:53 [PATCH 0/4 v2] Network Time plugin Antti Paila
2010-12-10  7:53 ` [PATCH 1/4 v2] plugins: Implementation of " Antti Paila
2010-12-10  7:53 ` [PATCH 2/4 v2] plugins: Enabling nettime plugin in Makefile.am Antti Paila
2010-12-10  7:53 ` [PATCH 3/4 v2] plugins: Test scripts for nettime plugin Antti Paila
2010-12-10  7:53 ` [PATCH 4/4 v2] plugins: Documentation " Antti Paila
2010-12-21  7:34 ` [PATCH 0/4 v2] Network Time plugin Antti Paila
2010-12-21 14:17   ` Marcel Holtmann [this message]
2010-12-21 15:54     ` Aki Niemi
2010-12-21 16:25       ` Marcel Holtmann
2010-12-21 17:04         ` Aki Niemi
2010-12-21 16:39       ` =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont
2010-12-21 17:02         ` Aki Niemi
2010-12-23  2:44       ` Marcel Holtmann
2011-01-03 15:00         ` =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont
2011-01-03 20:47           ` Marcel Holtmann
2011-01-04  8:54             ` =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont
2011-01-04  9:41               ` Marcel Holtmann
2011-01-04 13:37                 ` Aki Niemi
2011-01-04 21:49                   ` Marcel Holtmann
2011-01-05  8:29                     ` =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont
2011-01-05 10:14                       ` =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont
2011-01-07 10:32                     ` Antti Paila
2011-01-07 21:05                       ` Marcel Holtmann
2011-01-10  8:01                         ` =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1292941064.2658.29.camel@aeonflux \
    --to=marcel@holtmann.org \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox