Open Source Telephony
 help / color / mirror / Atom feed
From: Andrzej Zaborowski <andrew.zaborowski@intel.com>
To: ofono@ofono.org
Subject: [PATCH] n900: remove unneeded g_isi_client_destroy call.
Date: Thu, 23 Dec 2010 05:39:40 +0100	[thread overview]
Message-ID: <1293079181-13648-2-git-send-email-andrew.zaborowski@intel.com> (raw)
In-Reply-To: <1293079181-13648-1-git-send-email-andrew.zaborowski@intel.com>

[-- Attachment #1: Type: text/plain, Size: 493 bytes --]

"client" is either NULL or uninitialised in this place.
---
 plugins/n900.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/plugins/n900.c b/plugins/n900.c
index 711f4ed..29daf05 100644
--- a/plugins/n900.c
+++ b/plugins/n900.c
@@ -382,7 +382,6 @@ static int n900_probe(struct ofono_modem *modem)
 	return 0;
 
 error:
-	g_isi_client_destroy(client);
 	g_isi_modem_destroy(isimodem);
 	gpio_remove(modem);
 	g_free(isi);
-- 
1.7.1.86.g0e460.dirty


  reply	other threads:[~2010-12-23  4:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-23  4:39 [PATCH] gisi: fix use of unitialised variable Andrzej Zaborowski
2010-12-23  4:39 ` Andrzej Zaborowski [this message]
2010-12-24  0:26   ` [PATCH] n900: remove unneeded g_isi_client_destroy call Denis Kenzior
2010-12-23  4:39 ` [PATCH 1/2] stk: Send the AlphaId's to agent Andrzej Zaborowski
2010-12-24  0:32   ` Denis Kenzior
2010-12-24  0:26 ` [PATCH] gisi: fix use of unitialised variable Denis Kenzior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1293079181-13648-2-git-send-email-andrew.zaborowski@intel.com \
    --to=andrew.zaborowski@intel.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox