Open Source Telephony
 help / color / mirror / Atom feed
From: Yang Gu <gyagp0@gmail.com>
To: ofono@ofono.org
Subject: [PATCH 0/1] Patch Description
Date: Wed, 29 Dec 2010 00:14:14 +0800	[thread overview]
Message-ID: <1293552855-15949-1-git-send-email-gyagp0@gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 999 bytes --]

This patch is to cancel the pending sms via D-Bus. Till now, I'm still not sure what kind of sms should be cancelled. In theory, one message, or part of it, would be sent by oFono can be cancelled. For some examples: Any part of a message that has never been sent can be cancelled; one message was sent but failed, we can cancel before retry; One message is split into several pieces, we can cancel before all of them are sent. 
In current patch, I only cancel the sms that has never been sent. I wonder if it's enough or I should handle all the situations above. 

Another question here is about the existed code. There is a hashtable "messages" in struct ofono_sms. Can we store the state in the tx_queue_entry, and remove the hashtable thoroughly to make the code more simple?

Yang Gu (1):
  sms: Cancel pending message

 include/history.h |    1 +
 src/sms.c         |  132 ++++++++++++++++++++++++++++++++++++++++++-----------
 2 files changed, 106 insertions(+), 27 deletions(-)


             reply	other threads:[~2010-12-28 16:14 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-28 16:14 Yang Gu [this message]
2010-12-28 16:14 ` [PATCH 1/1] sms: Cancel pending message Yang Gu
2011-01-31 18:51   ` Lucas De Marchi
2011-02-01 15:59     ` Yang Gu
  -- strict thread matches above, loose matches on Subject: below --
2010-11-03  6:57 [PATCH 0/1] Patch Description Yang Gu
2010-09-24 15:49 Yang Gu
2010-09-25  3:00 ` Zhang, Zhenhua
2010-09-26 23:38 ` Denis Kenzior
2010-09-17  8:50 Yang Gu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1293552855-15949-1-git-send-email-gyagp0@gmail.com \
    --to=gyagp0@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox