Open Source Telephony
 help / color / mirror / Atom feed
From: martin.xu@intel.com
To: ofono@ofono.org
Subject: [PATCH 1/2] PPP: Fix Transmit ACCM and Receive ACCM setting error
Date: Mon, 10 Jan 2011 18:40:16 +0800	[thread overview]
Message-ID: <1294656017-825-2-git-send-email-martin.xu@intel.com> (raw)
In-Reply-To: <martin.xu@intel.com>

[-- Attachment #1: Type: text/plain, Size: 1318 bytes --]

From: Martin Xu <martin.xu@intel.com>

---
 gatchat/ppp_lcp.c |   13 +++++++++++--
 1 files changed, 11 insertions(+), 2 deletions(-)

diff --git a/gatchat/ppp_lcp.c b/gatchat/ppp_lcp.c
index 3a80a62..bc97257 100644
--- a/gatchat/ppp_lcp.c
+++ b/gatchat/ppp_lcp.c
@@ -149,7 +149,11 @@ static void lcp_rca(struct pppcp_data *pppcp, const struct pppcp_packet *packet)
 	while (ppp_option_iter_next(&iter) == TRUE) {
 		switch (ppp_option_iter_get_type(&iter)) {
 		case ACCM:
-			ppp_set_xmit_accm(pppcp_get_ppp(pppcp), 0);
+		/* RFC1662 Section 7.1
+		 * The Configuration Option is used to inform the peer which control
+		 * characters MUST remain mapped when the peer sends them.
+		 */
+			ppp_set_recv_accm(pppcp_get_ppp(pppcp), 0);
 			break;
 		default:
 			break;
@@ -263,7 +267,12 @@ static enum rcr_result lcp_rcr(struct pppcp_data *pppcp,
 	while (ppp_option_iter_next(&iter) == TRUE) {
 		switch (ppp_option_iter_get_type(&iter)) {
 		case ACCM:
-			ppp_set_recv_accm(ppp,
+		/* RFC1662 Section 7.1
+		 * The Configuration Option is used to inform the peer which control
+		 * characters MUST remain mapped when the peer sends them.
+		 */
+
+			ppp_set_xmit_accm(ppp,
 				get_host_long(ppp_option_iter_get_data(&iter)));
 			break;
 		case AUTH_PROTO:
-- 
1.7.2.2


             reply	other threads:[~2011-01-10 10:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-10 10:40 martin.xu [this message]
2011-01-11 17:06 ` [PATCH 1/2] PPP: Fix Transmit ACCM and Receive ACCM setting error Denis Kenzior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1294656017-825-2-git-send-email-martin.xu@intel.com \
    --to=martin.xu@intel.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox