From: Sjur =?unknown-8bit?q?Br=C3=A6ndeland?= <sjurbren@gmail.com>
To: ofono@ofono.org
Subject: [PATCH] coding-style: Use void if function has no parameters
Date: Tue, 11 Jan 2011 23:39:30 +0100 [thread overview]
Message-ID: <1294785570-2901-1-git-send-email-sjurbren@gmail.com> (raw)
In-Reply-To: <4D2CD1FE.4070601@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 913 bytes --]
From: Sjur Brændeland <sjur.brandeland@stericsson.com>
---
Marcel, Denis,
Here is the patch, please apply it if you agree. I'm easy :-)
Regards,
Sjur
doc/coding-style.txt | 15 +++++++++++++++
1 files changed, 15 insertions(+), 0 deletions(-)
diff --git a/doc/coding-style.txt b/doc/coding-style.txt
index 3bee240..40bb36b 100644
--- a/doc/coding-style.txt
+++ b/doc/coding-style.txt
@@ -279,6 +279,21 @@ memset(stuff, 0, sizeof(*stuff));
memset(stuff, 0, sizeof *stuff); // Wrong
+M15: Use void if function has no parameters
+===========================================================
+A function with no parameters must use void in the parameter list.
+
+Example:
+1)
+void foo(void)
+{
+}
+
+2)
+void foo() // Wrong
+{
+}
+
O1: Shorten the name
====================
Better to use abbreviation, rather than full name, to name a variable,
--
1.7.0.4
next prev parent reply other threads:[~2011-01-11 22:39 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-15 21:49 [PATCHv2] plugin: Add ste modem initd integration Sjur =?unknown-8bit?q?Br=C3=A6ndeland?=
2010-12-15 21:49 ` [PATCHv2 1/2] stemodem: Create network interfaces statically Sjur =?unknown-8bit?q?Br=C3=A6ndeland?=
2010-12-21 14:38 ` Marcel Holtmann
2010-12-15 21:49 ` [PATCHv2 2/2] stemodem: Use RTNL to create network interfaces Sjur =?unknown-8bit?q?Br=C3=A6ndeland?=
2010-12-21 14:38 ` Marcel Holtmann
2010-12-21 14:36 ` [PATCHv2] plugin: Add ste modem initd integration Marcel Holtmann
2010-12-21 15:06 ` Sjur =?unknown-8bit?q?Br=C3=A6ndeland?=
2010-12-21 15:18 ` Marcel Holtmann
2010-12-21 15:37 ` Sjur =?unknown-8bit?q?Br=C3=A6ndeland?=
2010-12-23 2:48 ` Marcel Holtmann
2011-01-03 21:42 ` Sjur =?unknown-8bit?q?Br=C3=A6ndeland?=
2011-01-03 21:55 ` Marcel Holtmann
2011-01-03 22:30 ` Sjur =?unknown-8bit?q?Br=C3=A6ndeland?=
2011-01-03 22:54 ` Marcel Holtmann
2011-01-03 23:12 ` Sjur =?unknown-8bit?q?Br=C3=A6ndeland?=
2011-01-04 9:49 ` Marcel Holtmann
2011-01-04 19:07 ` [PATCHv4 0/1] STE Modem Init Daemon integration Sjur =?unknown-8bit?q?Br=C3=A6ndeland?=
2011-01-04 19:07 ` [PATCHv4 1/1] plugin: Add ste modem initd integration Sjur =?unknown-8bit?q?Br=C3=A6ndeland?=
2011-01-05 22:06 ` Marcel Holtmann
2011-01-06 9:38 ` [PATCHv5] " Sjur =?unknown-8bit?q?Br=C3=A6ndeland?=
2011-01-11 0:58 ` Marcel Holtmann
2011-01-11 17:06 ` Sjur =?unknown-8bit?q?Br=C3=A6ndeland?=
2011-01-11 21:52 ` Marcel Holtmann
2011-01-11 21:56 ` Denis Kenzior
2011-01-11 22:05 ` Marcel Holtmann
2011-01-11 22:39 ` Sjur =?unknown-8bit?q?Br=C3=A6ndeland?= [this message]
2011-01-11 22:48 ` [PATCH] coding-style: Use void if function has no parameters Marcel Holtmann
2011-01-11 22:24 ` [PATCHv6] plugin: Add ste modem initd integration Sjur =?unknown-8bit?q?Br=C3=A6ndeland?=
2011-01-11 22:35 ` Marcel Holtmann
2011-01-11 22:41 ` Sjur =?unknown-8bit?q?Br=C3=A6ndeland?=
2011-01-11 22:56 ` [PATCHv7] " Sjur =?unknown-8bit?q?Br=C3=A6ndeland?=
2011-01-11 22:58 ` Marcel Holtmann
2010-12-21 22:54 ` [PATCHv3] " Sjur =?unknown-8bit?q?Br=C3=A6ndeland?=
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1294785570-2901-1-git-send-email-sjurbren@gmail.com \
--to=sjurbren@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox