From: Marcel Holtmann <marcel@holtmann.org>
To: ofono@ofono.org
Subject: Re: [PATCH 3/5 v3] nettime: DBUS and compilation configuration
Date: Tue, 18 Jan 2011 15:59:18 +0100 [thread overview]
Message-ID: <1295362758.3873.200.camel@aeonflux> (raw)
In-Reply-To: <AANLkTin-1_VfU2MRTbfb7JDDRByWQVwxOn+X9Uuu69su@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1245 bytes --]
Hi Aki,
> >> So these are redundant, unless the whole thing is rewritten as:
> >>
> >> <allow send_destination="org.ofono" send_interface="org.ofono.SimToolkitAgent"/>
> >> <allow send_destination="org.ofono" send_interface="org.ofono.PushNotificationAgent"/>
> >> <allow send_destination="org.ofono" send_interface="org.ofono.SmartMessagingAgent"/>
> >>
> >
> > The agents are registered by the application, not ofono. So the
> > destination is in fact not org.ofono but a system bus connection owned
> > by the application. Hence the need to punch holes here.
>
> This means we also need punch a hole for org.ofono.NetworkTime. The
> only difference there to the above agent interfaces is that it's a
> singleton and comes with no registration API on oFono side. Instead,
> there is a custom plugin per agent implementation, like the one for
> timed.
please don't implement org.ofono interface in timed. Just implement a
timed specific (com.nokia.time) interface and punch the whole for that
in the timed D-Bus policy.
The plugin is timed specific since it monitors com.nokia.time and thus
should also target a timed specific API. Not a generic oFono API
description.
Regards
Marcel
next prev parent reply other threads:[~2011-01-18 14:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-13 9:49 [PATCH 0/5 v3] Network Time plugin Antti Paila
2011-01-13 9:49 ` [PATCH 1/5 v3] nettime: Header file for nettime plugins Antti Paila
2011-01-13 12:58 ` Aki Niemi
2011-01-13 9:49 ` [PATCH 2/5 v3] nettime: Network time plugin implementation Antti Paila
2011-01-13 9:49 ` [PATCH 3/5 v3] nettime: DBUS and compilation configuration Antti Paila
2011-01-14 0:22 ` Marcel Holtmann
2011-01-17 8:17 ` Antti Paila
2011-01-17 16:09 ` Marcel Holtmann
2011-01-17 17:02 ` Mika.Liljeberg
2011-01-17 18:37 ` Denis Kenzior
2011-01-18 7:36 ` Aki Niemi
2011-01-18 14:59 ` Marcel Holtmann [this message]
2011-01-19 8:10 ` Aki Niemi
2011-01-20 11:19 ` Marcel Holtmann
2011-01-21 13:28 ` Antti Paila
2011-01-21 13:31 ` Marcel Holtmann
2011-01-13 9:49 ` [PATCH 4/5 v3] nettime: Documentation Antti Paila
2011-01-13 9:49 ` [PATCH 5/5 v3] nettime: Mock Timed for testing Antti Paila
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1295362758.3873.200.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox