From: Marcel Holtmann <marcel@holtmann.org>
To: ofono@ofono.org
Subject: Re: Ofono has too tight limits for SIM lock code lengths
Date: Thu, 27 Jan 2011 14:09:27 +0100 [thread overview]
Message-ID: <1296133767.1520.147.camel@aeonflux> (raw)
In-Reply-To: <1296132771-17621-1-git-send-email-jussi.kangas@tieto.com>
[-- Attachment #1: Type: text/plain, Size: 895 bytes --]
Hi Jussi,
> ---
> include/sim.h | 1 +
> src/call-barring.c | 14 ++++++++------
> src/call-meter.c | 4 ++--
> src/common.c | 29 ++++++++++++++++++++++++-----
> src/common.h | 11 +++--------
> src/ofono.h | 3 +++
> src/sim.c | 13 +++++++------
> 7 files changed, 48 insertions(+), 27 deletions(-)
>
> diff --git a/include/sim.h b/include/sim.h
> index 5e3ba5b..ee63d74 100644
> --- a/include/sim.h
> +++ b/include/sim.h
> @@ -54,6 +54,7 @@ enum ofono_sim_password_type {
> OFONO_SIM_PASSWORD_PHNETSUB_PUK,
> OFONO_SIM_PASSWORD_PHSP_PUK,
> OFONO_SIM_PASSWORD_PHCORP_PUK,
> + OFONO_PASSWORD_PIN_TYPE_NET,
> OFONO_SIM_PASSWORD_INVALID,
> };
so every single enum has kept some sort of proper namespacing. And I
would really prefer to not break this for ofono_sim_password_type.
Regards
Marcel
next prev parent reply other threads:[~2011-01-27 13:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-27 12:52 Ofono has too tight limits for SIM lock code lengths Jussi Kangas
2011-01-27 13:09 ` Marcel Holtmann [this message]
2011-01-27 14:31 ` Jussi Kangas
2011-01-28 15:20 ` Pekka Pessi
-- strict thread matches above, loose matches on Subject: below --
2011-01-19 9:04 Jussi Kangas
2011-01-20 17:35 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1296133767.1520.147.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox