From: Marcel Holtmann <marcel@holtmann.org>
To: ofono@ofono.org
Subject: Re: [PATCH 6/9] oFono smsagent enhancements to permit more flexible parameter set to be dispatched.
Date: Thu, 27 Jan 2011 14:18:22 +0100 [thread overview]
Message-ID: <1296134302.1520.154.camel@aeonflux> (raw)
In-Reply-To: <1293627085-24428-7-git-send-email-oleg.zhurakivskyy@nokia.com>
[-- Attachment #1: Type: text/plain, Size: 1064 bytes --]
Hi Oleg,
> src/smsagent.h | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/src/smsagent.h b/src/smsagent.h
> index 39513d6..348d36d 100644
> --- a/src/smsagent.h
> +++ b/src/smsagent.h
> @@ -31,6 +31,8 @@ typedef void (*sms_agent_dispatch_cb)(struct sms_agent *agent,
> enum sms_agent_result result,
> void *data);
>
> +typedef void (*sms_agent_dict_append_cb)(DBusMessageIter *dict, void *param);
> +
> struct sms_agent *sms_agent_new(const char *interface,
> const char *service, const char *path);
>
> @@ -49,4 +51,6 @@ int sms_agent_dispatch_datagram(struct sms_agent *agent, const char *method,
> const struct tm *local_sent_time,
> const unsigned char *content, unsigned int len,
> sms_agent_dispatch_cb cb, void *user_data,
> + sms_agent_dict_append_cb dict_cb,
> + void *dict_cb_data,
> ofono_destroy_func destroy);
I have a bunch of comments for the other patches, but what is this
about? I don't see any need to it.
Regards
Marcel
next prev parent reply other threads:[~2011-01-27 13:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-29 12:51 [PATCH 0/9] SMS history plugin Oleg Zhurakivskyy
2010-12-29 12:51 ` [PATCH 1/9] " Oleg Zhurakivskyy
2010-12-29 12:51 ` [PATCH 2/9] " Oleg Zhurakivskyy
2010-12-29 12:51 ` [PATCH 3/9] SMS history plugin documentation Oleg Zhurakivskyy
2010-12-29 12:51 ` [PATCH 4/9] SMS history plugin test script Oleg Zhurakivskyy
2010-12-29 12:51 ` [PATCH 5/9] oFono smsagent enhancements to permit more flexible parameter set to be dispatched Oleg Zhurakivskyy
2010-12-29 12:51 ` [PATCH 6/9] " Oleg Zhurakivskyy
2011-01-27 13:18 ` Marcel Holtmann [this message]
2011-01-27 14:38 ` oleg.zhurakivskyy
2011-01-27 22:40 ` Marcel Holtmann
2011-01-31 8:30 ` Oleg Zhurakivskyy
2010-12-29 12:51 ` [PATCH 7/9] Minor modifications due to sms_agent_dispatch_datagram() enhancements Oleg Zhurakivskyy
2010-12-29 12:51 ` [PATCH 8/9] " Oleg Zhurakivskyy
2010-12-29 12:51 ` [PATCH 9/9] D-Bus rules for SMS history plugin Oleg Zhurakivskyy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1296134302.1520.154.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox