Open Source Telephony
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: ofono@ofono.org
Subject: Re: [PATCH 1/3] sim: add ofono_sim_get_spn API header
Date: Thu, 27 Jan 2011 14:56:23 +0100	[thread overview]
Message-ID: <1296136583.1520.155.camel@aeonflux> (raw)
In-Reply-To: <1296134537-16133-2-git-send-email-jukka.saunamaki@nokia.com>

[-- Attachment #1: Type: text/plain, Size: 722 bytes --]

Hi Jukka,

>  include/sim.h |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/include/sim.h b/include/sim.h
> index 5e3ba5b..7e573fd 100644
> --- a/include/sim.h
> +++ b/include/sim.h
> @@ -180,6 +180,8 @@ void *ofono_sim_get_data(struct ofono_sim *sim);
>  const char *ofono_sim_get_imsi(struct ofono_sim *sim);
>  const char *ofono_sim_get_mcc(struct ofono_sim *sim);
>  const char *ofono_sim_get_mnc(struct ofono_sim *sim);
> +const char *ofono_sim_get_spn(struct ofono_sim *sim);
> +unsigned char ofono_sim_get_spn_dc(struct ofono_sim *sim);

what is the spn_dc for? We are converting everything into UTF-8 anyway
and that should be sufficient.

Regards

Marcel



  reply	other threads:[~2011-01-27 13:56 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-27 13:22 [PATCH 0/3] EF-SPN API to sim-atom Jukka Saunamaki
2011-01-27 13:22 ` [PATCH 1/3] sim: add ofono_sim_get_spn API header Jukka Saunamaki
2011-01-27 13:56   ` Marcel Holtmann [this message]
2011-01-27 14:04     ` Jukka Saunamaki
2011-01-27 13:22 ` [PATCH 2/3] sim: add ofono_sim_get_spn API implementation Jukka Saunamaki
2011-01-27 13:22 ` [PATCH 3/3] netreg: use ofono_sim_get_spn() Jukka Saunamaki
2011-01-31  6:13 ` [PATCH 0/3] EF-SPN API to sim-atom Jukka Saunamaki
2011-01-31  9:57   ` Marcel Holtmann
2011-01-31 20:22   ` Denis Kenzior
2011-02-01  7:25     ` Jukka Saunamaki
2011-02-01 10:38     ` Marcel Holtmann
2011-02-01 15:14       ` Denis Kenzior
2011-02-01 20:38         ` Aki Niemi
2011-02-02  1:20           ` Denis Kenzior
2011-02-02  7:19             ` Jukka Saunamaki
2011-02-02 16:01               ` Denis Kenzior
2011-02-02  7:12           ` Jukka Saunamaki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1296136583.1520.155.camel@aeonflux \
    --to=marcel@holtmann.org \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox