Re: [PATCH 1/5 v3] Cell-info: CellInfo DBUS interface definition

[Marcel Holtmann <marcel@holtmann.org>]

[-- Attachment #1: Type: text/plain, Size: 1306 bytes --]

Hi Antti,

>  include/dbus.h |    1 +
>  src/ofono.h    |    1 +
>  2 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/include/dbus.h b/include/dbus.h
> index 12768f6..f2e18bf 100644
> --- a/include/dbus.h
> +++ b/include/dbus.h
> @@ -45,6 +45,7 @@ extern "C" {
>  #define OFONO_MESSAGE_WAITING_INTERFACE "org.ofono.MessageWaiting"
>  #define OFONO_NETWORK_REGISTRATION_INTERFACE "org.ofono.NetworkRegistration"
>  #define OFONO_NETWORK_OPERATOR_INTERFACE "org.ofono.NetworkOperator"
> +#define OFONO_CELL_INFO_INTERFACE "org.ofono.CellInfo"
>  #define OFONO_PHONEBOOK_INTERFACE "org.ofono.Phonebook"
>  #define OFONO_RADIO_SETTINGS_INTERFACE "org.ofono.RadioSettings"
>  #define OFONO_AUDIO_SETTINGS_INTERFACE "org.ofono.AudioSettings"
> diff --git a/src/ofono.h b/src/ofono.h
> index cab70cd..820e3a3 100644
> --- a/src/ofono.h
> +++ b/src/ofono.h
> @@ -127,6 +127,7 @@ enum ofono_atom_type {
>  	OFONO_ATOM_TYPE_NETTIME = 21,
>  	OFONO_ATOM_TYPE_CTM = 22,
>  	OFONO_ATOM_TYPE_CDMA_VOICECALL_MANAGER = 23,
> +	OFONO_ATOM_TYPE_CELL_INFO = 24,
>  };

This is a little bit confusing since the atom enum doesn't really have
to do anything with the D-Bus interface name. You might wanna feed that
into some other patch or split it out.

Regards

Marcel