Open Source Telephony
 help / color / mirror / Atom feed
From: Antoine Reversat <a.reversat@gmail.com>
To: ofono@ofono.org
Subject: [PATCH 1/3] Clean up isi_call_any_address_sb_proc
Date: Fri, 25 Feb 2011 14:23:16 -0500	[thread overview]
Message-ID: <1298661798-4059-1-git-send-email-a.reversat@gmail.com> (raw)
In-Reply-To: <AANLkTik_2_gbnD3EgGJkAtQj8OBHWXA6nY093LSJDN5V@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 916 bytes --]

---
 drivers/isimodem/voicecall.c |   14 ++++++++++----
 1 files changed, 10 insertions(+), 4 deletions(-)

diff --git a/drivers/isimodem/voicecall.c b/drivers/isimodem/voicecall.c
index 0a32f27..0f9753b 100644
--- a/drivers/isimodem/voicecall.c
+++ b/drivers/isimodem/voicecall.c
@@ -210,10 +210,16 @@ static void isi_call_any_address_sb_proc(struct isi_voicecall *ivc,
 	uint8_t len;
 	char *addr;
 
-	if (!g_isi_sb_iter_get_byte(sb, &type, 2) ||
-			!g_isi_sb_iter_get_byte(sb, &pres, 3) ||
-			!g_isi_sb_iter_get_byte(sb, &len, 5) ||
-			!g_isi_sb_iter_get_alpha_tag(sb, &addr, 2 * len, 6))
+	if (!g_isi_sb_iter_get_byte(sb, &type, 2))
+		return;
+
+	if (!g_isi_sb_iter_get_byte(sb, &pres, 3))
+		return;
+
+	if (!g_isi_sb_iter_get_byte(sb, &len, 5))
+		return;
+
+	if (!g_isi_sb_iter_get_alpha_tag(sb, &addr, 2 * len, 6))
 		return;
 
 	call->addr_type = type | 0x80;
-- 
1.7.1


       reply	other threads:[~2011-02-25 19:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <AANLkTik_2_gbnD3EgGJkAtQj8OBHWXA6nY093LSJDN5V@mail.gmail.com>
2011-02-25 19:23 ` Antoine Reversat [this message]
2011-02-25 20:22   ` [PATCH 1/3] Clean up isi_call_any_address_sb_proc Denis Kenzior
2011-02-25 19:23 ` [PATCH 2/3] Add CNAP support for isimodem Antoine Reversat
2011-02-25 19:23 ` [PATCH 3/3] Add CNAP debugging ofono voicecall Antoine Reversat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1298661798-4059-1-git-send-email-a.reversat@gmail.com \
    --to=a.reversat@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox