Open Source Telephony
 help / color / mirror / Atom feed
From: Miia Leinonen <miia.leinonen@tieto.com>
To: ofono@ofono.org
Subject: Re: [PATCH] atmodem: Add MBM/STE quirk for SIM record update
Date: Mon, 28 Feb 2011 09:22:03 +0200	[thread overview]
Message-ID: <1298877723.1616.7.camel@miia-desktop> (raw)
In-Reply-To: <1298448563-5033-1-git-send-email-miia.leinonen@tieto.com>

[-- Attachment #1: Type: text/plain, Size: 624 bytes --]


Hi,

On Wed, 2011-02-23 at 10:09 +0200, Miia Leinonen wrote:
> Fixed the <data> string to be set inside quotes for STE/MBM.
> 
> ---
> 
> Hi,
> 
> This fix has been tested with STE modem only due the lack of MBM HW.
> 
> Would it be possible that someone checks this with MBM modem? The problem is 
> likely to appear also there - therefore OFONO_VENDOR_MBM used. Could fix this 
> also to cover all modems, but that might cause some backward compatibility 
> issues.
> 
> BR,
> Miia

Is this fix OK or should I use some other approach? No one seem to have
commented anything so far.

BR,
Miia



  reply	other threads:[~2011-02-28  7:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-23  8:09 [PATCH] atmodem: Add MBM/STE quirk for SIM record update Miia Leinonen
2011-02-28  7:22 ` Miia Leinonen [this message]
2011-03-01 21:30 ` Denis Kenzior
2011-03-02 12:56   ` [PATCH v2] atmodem: Add MBM vendor " Miia Leinonen
2011-03-03  4:55     ` Denis Kenzior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1298877723.1616.7.camel@miia-desktop \
    --to=miia.leinonen@tieto.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox