Re: [PATCH] atmodem: Enable network time for AT modem

[Marcel Holtmann <marcel@holtmann.org>]

[-- Attachment #1: Type: text/plain, Size: 881 bytes --]

Hi Antti,

>  drivers/atmodem/network-registration.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/atmodem/network-registration.c b/drivers/atmodem/network-registration.c
> index 4913611..2d589f0 100644
> --- a/drivers/atmodem/network-registration.c
> +++ b/drivers/atmodem/network-registration.c
> @@ -722,6 +722,8 @@ static void ifx_ctzv_notify(GAtResult *result, gpointer user_data)
>  	nd->time.mday = mday;
>  	nd->time.mon = mon;
>  	nd->time.year = 2000 + year;
> +
> +	ofono_netreg_time_notify(netreg, &nd->time);
>  }
>  
>  static void ifx_ctzdst_notify(GAtResult *result, gpointer user_data)

actually this time notification is a bad idea since you will notify
twice now. With the firmware that I tested this with, it is guaranteed
to always get CTZV and CTZDST and in that order.

Regards

Marcel