Open Source Telephony
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: ofono@ofono.org
Subject: Re: [PATCH 2/6] stk-api.txt. Introduce the new API ConfirmOpenChannel
Date: Fri, 08 Apr 2011 09:36:39 -0700	[thread overview]
Message-ID: <1302280599.2572.202.camel@aeonflux> (raw)
In-Reply-To: <1302280411-20762-2-git-send-email-philippe.nunes@linux.intel.com>

[-- Attachment #1: Type: text/plain, Size: 920 bytes --]

Hi Philippe,

>  doc/stk-api.txt |    7 +++++++
>  1 files changed, 7 insertions(+), 0 deletions(-)
> 
> diff --git a/doc/stk-api.txt b/doc/stk-api.txt
> index 0bcc6b5..aaa9fba 100644
> --- a/doc/stk-api.txt
> +++ b/doc/stk-api.txt
> @@ -278,6 +278,13 @@ Methods		byte RequestSelection(string title, byte icon_id,
>  
>  			Possible Errors: [service].Error.SimToolkit.EndSession
>  
> +		boolean ConfirmOpenChannel(string information, byte icon_id)
> +
> +			Asks the agent to request user to confirm the channel
> +			set-up.
> +
> +			Possible Errors: [service].Error.SimToolkit.EndSession
> +

we need to talk a bit about these boolean return parameters for
confirmation. Since essentially a positive D-Bus reply can be considered
as TRUE and a D-Bus error as FALSE. So this essentially implicit.

You can not return FALSE and an error. That is not how D-Bus works.

Regards

Marcel



  reply	other threads:[~2011-04-08 16:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-08 16:33 [PATCH 2/6] stk-api.txt. Introduce the new API ConfirmOpenChannel Philippe Nunes
2011-04-08 16:36 ` Marcel Holtmann [this message]
2011-04-08 16:59   ` Denis Kenzior
2011-04-09 13:53     ` Marcel Holtmann
2011-04-12  4:39 ` Denis Kenzior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1302280599.2572.202.camel@aeonflux \
    --to=marcel@holtmann.org \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox