From: Nicolas Bertrand <nicolas.bertrand@linux.intel.com>
To: ofono@ofono.org
Subject: [PATCH] callmanager: Remove connect and alert timers
Date: Thu, 12 May 2011 14:55:25 +0200 [thread overview]
Message-ID: <1305204925-4687-1-git-send-email-nicolas.bertrand@linux.intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 3854 bytes --]
---
src/callmanager.cpp | 29 -----------------------------
src/callmanager.h | 2 --
2 files changed, 0 insertions(+), 31 deletions(-)
diff --git a/src/callmanager.cpp b/src/callmanager.cpp
index 8085056..fb132b5 100644
--- a/src/callmanager.cpp
+++ b/src/callmanager.cpp
@@ -31,14 +31,6 @@ CallManager::CallManager( QObject *parent )
_multipartyLimit = -1;
numRings = 0;
- connectTimer = new QTimer(this);
- connectTimer->setSingleShot(true);
- connect( connectTimer, SIGNAL(timeout()), this, SLOT(dialingToConnected()) );
-
- alertingTimer = new QTimer(this);
- alertingTimer->setSingleShot(true);
- connect( alertingTimer, SIGNAL(timeout()), this, SLOT(dialingToAlerting()) );
-
hangupTimer = new QTimer(this);
hangupTimer->setSingleShot(true);
connect( hangupTimer, SIGNAL(timeout()), this, SLOT(hangupTimeout()) );
@@ -155,10 +147,6 @@ bool CallManager::command( const QString& cmd )
sendState( info );
send( "OK" );
- // Start timers to transition the dialing call to alerting and connected.
- alertingTimer->start(2500);
- connectTimer->start(3000);
-
// Data call - phone number 696969
} else if ( cmd.startsWith( "ATD" ) ) {
// Data call setup.
@@ -183,10 +171,6 @@ bool CallManager::command( const QString& cmd )
// Advertise the call state change and then return to command mode.
sendState( info );
send( "CONNECT 19200" );
-
- // Start timers to transition the dialing call to alerting and connected.
- alertingTimer->start(2500);
- connectTimer->start(3000);
} else {
// If not a data line
emit send( "NO CARRIER" );
@@ -397,8 +381,6 @@ void CallManager::hangupAll()
sendState( callList[index] );
}
callList.clear();
- connectTimer->stop();
- alertingTimer->stop();
hangupTimer->stop();
emit callStatesChanged( &callList );
}
@@ -533,8 +515,6 @@ bool CallManager::chld1()
} else if ( ( id = idForDialing() ) >= 0 ) {
// We have a dialing call.
hangupCall(id);
- connectTimer->stop();
- alertingTimer->stop();
hangupTimer->stop();
return true;
} else {
@@ -550,8 +530,6 @@ bool CallManager::chld1x( int x )
if ( callList[index].id == x ) {
if ( callList[index].state == CallState_Dialing ||
callList[index].state == CallState_Alerting ) {
- connectTimer->stop();
- alertingTimer->stop();
hangupTimer->stop();
}
callList[index].state = CallState_Hangup;
@@ -700,10 +678,6 @@ bool CallManager::chld4()
void CallManager::dialingToConnected()
{
- // Stop timers in case they are still active
- alertingTimer->stop();
- connectTimer->stop();
-
// Find the currently dialing or alerting call.
int index = indexForId( idForState( CallState_Dialing ) );
if ( index < 0 )
@@ -730,9 +704,6 @@ void CallManager::dialingToConnected()
void CallManager::dialingToAlerting()
{
- // Stop the timer in case it is still active
- alertingTimer->stop();
-
// Find the currently dialing or alerting call.
int index = indexForId( idForState( CallState_Dialing ) );
if ( index < 0 )
diff --git a/src/callmanager.h b/src/callmanager.h
index c953a7d..ff3ac30 100644
--- a/src/callmanager.h
+++ b/src/callmanager.h
@@ -143,8 +143,6 @@ private slots:
private:
QList<CallInfo> callList;
- QTimer *connectTimer;
- QTimer *alertingTimer;
QTimer *hangupTimer;
QTimer *ringTimer;
bool _holdWillFail;
--
1.7.1
next reply other threads:[~2011-05-12 12:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-12 12:55 Nicolas Bertrand [this message]
2011-05-17 4:40 ` [PATCH] callmanager: Remove connect and alert timers Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1305204925-4687-1-git-send-email-nicolas.bertrand@linux.intel.com \
--to=nicolas.bertrand@linux.intel.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox