From: Aki Niemi <aki.niemi@nokia.com>
To: ofono@ofono.org
Subject: Re: build fail with --disable-atmodem
Date: Wed, 01 Jun 2011 10:35:15 +0300 [thread overview]
Message-ID: <1306913715.18038.3071.camel@tucson> (raw)
In-Reply-To: <0LM300AW9KJAISM0@mailout4.samsung.com>
[-- Attachment #1: Type: text/plain, Size: 453 bytes --]
On Wed, 2011-06-01 at 05:57 +0000, ext 오인호 wrote:
> i tried to compile with --disable-atmodem, an error occurred.
>
> please help what to do. (i want only isimodem)
>
> - without --disable-atmodem, compile success.
I sent a patch on 24.3. that fixes the issue. Gatchat is now required to
build core, but gets disabled along with atmodem.
Maybe Marcel or Denis could take a look at that patch (reattaching it
here).
Cheers,
Aki
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-build-Add-gatchat-to-core-sources.patch --]
[-- Type: text/x-patch, Size: 1426 bytes --]
>From 1920b813a4db120f0d6692e9d4d86f3fe313a263 Mon Sep 17 00:00:00 2001
From: Aki Niemi <aki.niemi@nokia.com>
Date: Thu, 24 Mar 2011 17:30:12 +0200
Subject: [PATCH] build: Add gatchat to core sources
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Otherwise, --disable-atmodem breaks build.
---
Makefile.am | 9 ++++-----
1 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/Makefile.am b/Makefile.am
index b0cbcd7..39d8962 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -154,8 +154,7 @@ endif
if ATMODEM
builtin_modules += atmodem
-builtin_sources += $(gatchat_sources) \
- drivers/atmodem/atmodem.h \
+builtin_sources += drivers/atmodem/atmodem.h \
drivers/atmodem/atmodem.c \
drivers/atmodem/call-settings.c \
drivers/atmodem/sms.c \
@@ -365,9 +364,9 @@ builtin_sources += plugins/push-notification.c
sbin_PROGRAMS = src/ofonod
-src_ofonod_SOURCES = $(gdbus_sources) $(builtin_sources) src/ofono.ver \
- src/main.c src/ofono.h src/log.c src/plugin.c \
- src/modem.c src/common.h src/common.c \
+src_ofonod_SOURCES = $(gdbus_sources) $(builtin_sources) $(gatchat_sources) \
+ src/ofono.ver src/main.c src/ofono.h src/log.c \
+ src/plugin.c src/modem.c src/common.h src/common.c \
src/manager.c src/dbus.c src/util.h src/util.c \
src/network.c src/voicecall.c src/ussd.c src/sms.c \
src/call-settings.c src/call-forwarding.c \
--
1.7.1
prev parent reply other threads:[~2011-06-01 7:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-01 5:57 build fail with --disable-atmodem =?unknown-8bit?b?7Jik7J247Zi4?=
2011-06-01 7:35 ` Aki Niemi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1306913715.18038.3071.camel@tucson \
--to=aki.niemi@nokia.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox