From: Marcel Holtmann <marcel@holtmann.org>
To: ofono@ofono.org
Subject: Re: [PATCH_v2 3/3] speedupcdma: register to cdma network registration atom.
Date: Sat, 23 Jul 2011 17:00:55 +0200 [thread overview]
Message-ID: <1311433255.21109.347.camel@aeonflux> (raw)
In-Reply-To: <1311394170-7381-4-git-send-email-bertrand.aygon@intel.com>
[-- Attachment #1: Type: text/plain, Size: 979 bytes --]
Hi Bertrand,
> plugins/speedupcdma.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/plugins/speedupcdma.c b/plugins/speedupcdma.c
> index b7e54a1..14189aa 100644
> --- a/plugins/speedupcdma.c
> +++ b/plugins/speedupcdma.c
> @@ -36,6 +36,7 @@
> #include <ofono/modem.h>
> #include <ofono/devinfo.h>
> #include <ofono/cdma-connman.h>
> +#include <ofono/cdma-netreg.h>
> #include <ofono/log.h>
>
> #include <drivers/atmodem/atutil.h>
> @@ -181,6 +182,8 @@ static void speedupcdma_post_online(struct ofono_modem *modem)
>
> DBG("%p", modem);
>
> + ofono_cdma_netreg_create(modem, 0, "cdmamodem", data->chat);
> +
> ofono_cdma_connman_create(modem, 0, "cdmamodem", data->chat);
earlier you mentioned that the Speed Up modems have more than one TTY. I
don't think it is a good idea to run the netreg handling on the same TTY
where we will eventually establish the PPP connection.
Regards
Marcel
prev parent reply other threads:[~2011-07-23 15:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-23 4:09 [PATCH_v2 0/3] Create CDMA Network Registration atom Bertrand Aygon
2011-07-23 4:09 ` [PATCH_v2 1/3] cdmamodem: Create org.ofono.cdma.NetworkRegistration interface Bertrand Aygon
2011-07-23 14:52 ` Marcel Holtmann
2011-07-23 4:09 ` [PATCH_v2 2/3] cdmamodem: Create network registration atom Bertrand Aygon
2011-07-23 14:59 ` Marcel Holtmann
2011-07-23 15:11 ` Denis Kenzior
2011-07-23 15:15 ` Aygon, Bertrand
2011-07-23 15:23 ` Denis Kenzior
2011-07-23 4:09 ` [PATCH_v2 3/3] speedupcdma: register to cdma " Bertrand Aygon
2011-07-23 15:00 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1311433255.21109.347.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox