From: Marcel Holtmann <marcel@holtmann.org>
To: ofono@ofono.org
Subject: RE: [PATCH] cdmamodem: create vendor.h file.
Date: Mon, 25 Jul 2011 18:58:34 +0200 [thread overview]
Message-ID: <1311613119.8920.21.camel@aeonflux> (raw)
In-Reply-To: <568DE01DA537804BA73470071BAC288938F4E5AB@irsmsx503.ger.corp.intel.com>
[-- Attachment #1: Type: text/plain, Size: 592 bytes --]
H Bertrand,
> > And from were I am standing, feel free to share the vendor quirks from
> > atmodem/vendor.h. At least until we have the rest figured out.
>
> Ok, and what about the GENERIC, are we creating one? I don't think that this is a good idea.
the atom driver by default should implement generic behavior. Aka vendor
set to 0. Only quirk behavior should be implemented via this. And that
only if it shares like 95% of the functionality otherwise. If it not
share that much, then just add another atom driver. So clearly no to the
GENERIC thing.
Regards
Marcel
prev parent reply other threads:[~2011-07-25 16:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-23 11:04 [PATCH] cdmamodem: create vendor.h file Bertrand Aygon
2011-07-23 11:08 ` Aygon, Bertrand
2011-07-23 15:05 ` Marcel Holtmann
2011-07-25 14:30 ` Aygon, Bertrand
2011-07-25 14:44 ` Marcel Holtmann
2011-07-25 15:00 ` Aygon, Bertrand
2011-07-25 6:23 ` Denis Kenzior
2011-07-25 16:58 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1311613119.8920.21.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox