Open Source Telephony
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: ofono@ofono.org
Subject: Re: [PATCH 2/4] speedup: Create SIM atom with SpeedUp vendor to handle proprietary commands
Date: Wed, 27 Jul 2011 16:15:02 +0200	[thread overview]
Message-ID: <1311776102.8920.67.camel@aeonflux> (raw)
In-Reply-To: <1311351329-1241-3-git-send-email-philippe.nunes@linux.intel.com>

[-- Attachment #1: Type: text/plain, Size: 1199 bytes --]

Hi Philippe,

>  drivers/atmodem/sim.c |    1 +
>  plugins/speedup.c     |    2 +-
>  2 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/atmodem/sim.c b/drivers/atmodem/sim.c
> index 2690ab4..a4a09f5 100644
> --- a/drivers/atmodem/sim.c
> +++ b/drivers/atmodem/sim.c
> @@ -151,6 +151,7 @@ static void at_sim_read_info(struct ofono_sim *sim, int fileid,
>  	case OFONO_VENDOR_HUAWEI:
>  	case OFONO_VENDOR_SIERRA:
>  	case OFONO_VENDOR_QUALCOMM_MSM:
> +	case OFONO_VENDOR_SPEEDUP:

sort this one before the QUALCOMM_MSM quirk.

>  		strcat(buf, ",0,0,255"); /* Maximum possible length */
>  		break;
>  	}
> diff --git a/plugins/speedup.c b/plugins/speedup.c
> index 23ba173..9302dcc 100644
> --- a/plugins/speedup.c
> +++ b/plugins/speedup.c
> @@ -330,7 +330,7 @@ static void speedup_pre_sim(struct ofono_modem *modem)
>  	DBG("%p", modem);
>  
>  	ofono_devinfo_create(modem, 0, "atmodem", data->aux);
> -	sim = ofono_sim_create(modem, OFONO_VENDOR_QUALCOMM_MSM,
> +	sim = ofono_sim_create(modem, OFONO_VENDOR_SPEEDUP,
>  				"atmodem", data->aux);

And patch does not apply anymore. Please send me an updated one.

Regards

Marcel



  reply	other threads:[~2011-07-27 14:15 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-22 16:15 [PATCH 0/4] ZTE/SpeedUp specificities Philippe Nunes
2011-07-22 16:15 ` [PATCH 1/4] atmodem: Add vendor entry for SpeedUp modems Philippe Nunes
2011-07-27 14:13   ` Marcel Holtmann
2011-07-22 16:15 ` [PATCH 2/4] speedup: Create SIM atom with SpeedUp vendor to handle proprietary commands Philippe Nunes
2011-07-27 14:15   ` Marcel Holtmann [this message]
2011-07-22 16:15 ` [PATCH 3/4] atmodem: Add a polling based on CPIN query to detect SIM state change Philippe Nunes
2011-07-27 14:19   ` Marcel Holtmann
2011-07-22 16:15 ` [PATCH 4/4] atmodem: Add support for the PIN counter command AT+CPNNUM Philippe Nunes
2011-07-22 14:05   ` Denis Kenzior
2011-07-27 14:17   ` Marcel Holtmann
2011-08-04  7:34     ` Aygon, Bertrand
2011-08-04 15:44       ` Marcel Holtmann
2011-08-04 15:56         ` Aygon, Bertrand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1311776102.8920.67.camel@aeonflux \
    --to=marcel@holtmann.org \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox