Open Source Telephony
 help / color / mirror / Atom feed
From: Philippe Nunes <philippe.nunes@linux.intel.com>
To: ofono@ofono.org
Subject: [PATCH v2 3/5] udevng.c: tty assignment according OFONO_LABEL should take precedence
Date: Mon, 29 Aug 2011 18:41:49 +0200	[thread overview]
Message-ID: <1314636111-16146-4-git-send-email-philippe.nunes@linux.intel.com> (raw)
In-Reply-To: <1314636111-16146-1-git-send-email-philippe.nunes@linux.intel.com>

[-- Attachment #1: Type: text/plain, Size: 3982 bytes --]

---
 plugins/udevng.c |   52 ++++++++++++++++++++++++++++++----------------------
 1 files changed, 30 insertions(+), 22 deletions(-)

diff --git a/plugins/udevng.c b/plugins/udevng.c
index 1365bd1..40cc1ff 100644
--- a/plugins/udevng.c
+++ b/plugins/udevng.c
@@ -264,16 +264,18 @@ static gboolean setup_huawei(struct modem_info *modem)
 			if (mdm != NULL && pcui != NULL)
 				break;
 		} else if (g_strcmp0(info->interface, "255/255/255") == 0) {
-			if (g_strcmp0(info->number, "00") == 0)
+			if (mdm == NULL && g_strcmp0(info->number, "00") == 0)
 				mdm = info->devnode;
-			else if (g_strcmp0(info->number, "01") == 0)
-				pcui = info->devnode;
-			else if (g_strcmp0(info->number, "02") == 0)
-				pcui = info->devnode;
-			else if (g_strcmp0(info->number, "03") == 0)
-				pcui = info->devnode;
-			else if (g_strcmp0(info->number, "04") == 0)
-				pcui = info->devnode;
+			else if (pcui == NULL) {
+				if (g_strcmp0(info->number, "01") == 0)
+					pcui = info->devnode;
+				else if (g_strcmp0(info->number, "02") == 0)
+					pcui = info->devnode;
+				else if (g_strcmp0(info->number, "03") == 0)
+					pcui = info->devnode;
+				else if (g_strcmp0(info->number, "04") == 0)
+					pcui = info->devnode;
+			}
 		}
 	}
 
@@ -311,12 +313,14 @@ static gboolean setup_speedup(struct modem_info *modem)
 			if (aux != NULL)
 				break;
 		} else if (g_strcmp0(info->interface, "255/255/255") == 0) {
-			if (g_strcmp0(info->number, "01") == 0)
+			if ( aux == NULL && g_strcmp0(info->number, "01") == 0)
 				aux = info->devnode;
-			else if (g_strcmp0(info->number, "02") == 0)
-				mdm = info->devnode;
-			else if (g_strcmp0(info->number, "03") == 0)
-				mdm = info->devnode;
+			else if (mdm == NULL) {
+				if (g_strcmp0(info->number, "02") == 0)
+					mdm = info->devnode;
+				else if (g_strcmp0(info->number, "03") == 0)
+					mdm = info->devnode;
+			}
 		}
 	}
 
@@ -385,9 +389,10 @@ static gboolean setup_alcatel(struct modem_info *modem)
 			if (aux != NULL)
 				break;
 		} else if (g_strcmp0(info->interface, "255/255/255") == 0) {
-			if (g_strcmp0(info->number, "03") == 0)
+			if (aux == NULL && g_strcmp0(info->number, "03") == 0)
 				aux = info->devnode;
-			else if (g_strcmp0(info->number, "05") == 0)
+			else if (mdm == NULL &&
+					g_strcmp0(info->number, "05") == 0)
 				mdm = info->devnode;
 		}
 	}
@@ -425,9 +430,10 @@ static gboolean setup_novatel(struct modem_info *modem)
 			if (aux != NULL)
 				break;
 		} else if (g_strcmp0(info->interface, "255/255/255") == 0) {
-			if (g_strcmp0(info->number, "00") == 0)
+			if (aux == NULL && g_strcmp0(info->number, "00") == 0)
 				aux = info->devnode;
-			else if (g_strcmp0(info->number, "01") == 0)
+			else if (mdm == NULL &&
+					g_strcmp0(info->number, "01") == 0)
 				mdm = info->devnode;
 		}
 	}
@@ -465,9 +471,10 @@ static gboolean setup_nokia(struct modem_info *modem)
 			if (aux != NULL)
 				break;
 		} else if (g_strcmp0(info->interface, "10/0/0") == 0) {
-			if (g_strcmp0(info->number, "02") == 0)
+			if (mdm == NULL && g_strcmp0(info->number, "02") == 0)
 				mdm = info->devnode;
-			else if (g_strcmp0(info->number, "04") == 0)
+			else if (aux == NULL &&
+					g_strcmp0(info->number, "04") == 0)
 				aux = info->devnode;
 		}
 	}
@@ -505,13 +512,14 @@ static gboolean setup_telit(struct modem_info *modem)
 			if (aux != NULL)
 				break;
 		} else if (g_strcmp0(info->interface, "255/255/255") == 0) {
-			if (g_strcmp0(info->number, "00") == 0)
+			if (mdm == NULL && g_strcmp0(info->number, "00") == 0)
 				mdm = info->devnode;
 			else if (g_strcmp0(info->number, "01") == 0)
 				diag = info->devnode;
 			else if (g_strcmp0(info->number, "02") == 0)
 				gps = info->devnode;
-			else if (g_strcmp0(info->number, "03") == 0)
+			else if (aux == NULL
+					&& g_strcmp0(info->number, "03") == 0)
 				aux = info->devnode;
 		}
 	}
-- 
1.7.1


  parent reply	other threads:[~2011-08-29 16:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-29 16:41 [PATCH v2 0/5] udev rules update Philippe Nunes
2011-08-29 16:41 ` [PATCH v2 1/5] udev: Add rules to support ZTE MF668 dongle Philippe Nunes
2011-08-29 16:41 ` [PATCH v2 2/5] udev: Add rules to support ZTE MF190 dongle Philippe Nunes
2011-08-29 16:41 ` Philippe Nunes [this message]
2011-08-29 16:41 ` [PATCH v2 4/5] udev: Add rules to support Speedup 7300 dongle Philippe Nunes
2011-08-29 16:41 ` [PATCH v2 5/5] udev: Add rules to support SpeedUp 9800 dongle Philippe Nunes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1314636111-16146-4-git-send-email-philippe.nunes@linux.intel.com \
    --to=philippe.nunes@linux.intel.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox