From: Marcel Holtmann <marcel@holtmann.org>
To: ofono@ofono.org
Subject: Re: [PATCH 0/5] udev rules update
Date: Tue, 29 Nov 2011 13:20:39 +0100 [thread overview]
Message-ID: <1322569239.29909.61.camel@aeonflux> (raw)
In-Reply-To: <1322569281-10908-1-git-send-email-philippe.nunes@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1209 bytes --]
Hi Philippe,
> This set of patches have been sent this summer but not upstreamed.
> As few bugs have been opened which could be fixed by those patches, I resend them
> for review.
>
> - For Speedup dongles, the logic in udevng is to assign the modem port on the
> latest interface. This is not true for SpeedUp SU-7300U (BUG #23168) and
> SpeedUp 9800 (BUG #23167). So, I added 2 specific rules for both dongles.
>
> - For dongle ZTE MF190, 6 interfaces are present and we shall use the interface
> ttyUSB4 for modem channel. The logic in udevng is to assign the modem channel
> on the latest interface. To not break the support of ZTE modems with 5
> interfaces (which are using the 4th one for PPP, like K3570), I can't extend
> the current logic to take into account the ttyUSB4. So, I added a specific rule
> for ZTE MF190.
> I added also a specific rule for the dongle ZTE MF668 as the modem channel is
> not on the latest interface (BUG #23683)
why is all this reasoning here and not in the commit message of the
patches? I expect that every patch has a proper commit message that
explains its goal. Just a non-meaningful subject line is not enough.
Regards
Marcel
next prev parent reply other threads:[~2011-11-29 12:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-29 12:21 [PATCH 0/5] udev rules update Philippe Nunes
2011-11-29 12:20 ` Marcel Holtmann [this message]
2011-11-29 14:51 ` Philippe Nunes
2011-11-29 12:21 ` [PATCH 1/5] udev: Add rules to support ZTE MF668 dongle Philippe Nunes
2011-12-19 5:49 ` Marcel Holtmann
2011-12-19 17:34 ` Philippe Nunes
2011-11-29 12:21 ` [PATCH 2/5] udev: Add rules to support ZTE MF190 dongle Philippe Nunes
2011-12-19 5:50 ` Marcel Holtmann
2011-12-19 17:45 ` Philippe Nunes
2011-11-29 12:21 ` [PATCH 3/5] udevng.c: tty assignment according OFONO_LABEL should take precedence Philippe Nunes
2011-12-19 5:48 ` Marcel Holtmann
2011-12-19 16:32 ` Philippe Nunes
2011-11-29 12:21 ` [PATCH 4/5] udev: Add rules to support Speedup 7300 dongle Philippe Nunes
2011-12-19 5:51 ` Marcel Holtmann
2011-11-29 12:21 ` [PATCH 5/5] udev: Add rules to support SpeedUp 9800 dongle Philippe Nunes
2011-12-19 5:52 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1322569239.29909.61.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox