From: Marcel Holtmann <marcel@holtmann.org>
To: ofono@ofono.org
Subject: Re: [PATCH v2 06/12] gatchat: Add possibility to associate a diagnostic monitor to the AT-capable port
Date: Thu, 08 Dec 2011 16:13:23 +0200 [thread overview]
Message-ID: <1323353603.1965.42.camel@aeonflux> (raw)
In-Reply-To: <1323355803-22096-7-git-send-email-philippe.nunes@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 759 bytes --]
Hi Philippe,
> gatchat/gatchat.c | 26 ++++++++++++++++++++++++++
> gatchat/gatchat.h | 4 ++++
> 2 files changed, 30 insertions(+), 0 deletions(-)
>
> diff --git a/gatchat/gatchat.c b/gatchat/gatchat.c
> index 7a0ef35..00e5fa8 100644
> --- a/gatchat/gatchat.c
> +++ b/gatchat/gatchat.c
> @@ -35,6 +35,7 @@
> #include "ringbuffer.h"
> #include "gatchat.h"
> #include "gatio.h"
> +#include "gathdlc.h"
>
> /* #define WRITE_SCHEDULER_DEBUG 1 */
>
> @@ -110,6 +111,7 @@ struct _GAtChat {
> struct at_chat *parent;
> guint group;
> GAtChat *slave;
> + GAtHDLC *diag_monitor;
> };
what is this for? I don't see this needed at all. You are not crossing
atom driver implementations anyway.
Regards
Marcel
next prev parent reply other threads:[~2011-12-08 14:13 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-08 14:49 [PATCH v2 00/12] Provider name and SID Philippe Nunes
2011-12-08 14:49 ` [PATCH v2 01/12] cdma-providers: add driver APIs header Philippe Nunes
2011-12-09 11:50 ` Denis Kenzior
2011-12-08 14:49 ` [PATCH v2 02/12] ofono.h: add cdma-providers Philippe Nunes
2011-12-09 11:52 ` Denis Kenzior
2011-12-08 14:49 ` [PATCH v2 03/12] cdma-providers: add driver APIs implementation Philippe Nunes
2011-12-08 14:49 ` [PATCH v2 04/12] providers: Add cdma provider name plugin Philippe Nunes
2011-12-08 14:49 ` [PATCH v2 05/12] cdma-netreg: Add provider name and SID support Philippe Nunes
2011-12-08 14:49 ` [PATCH v2 06/12] gatchat: Add possibility to associate a diagnostic monitor to the AT-capable port Philippe Nunes
2011-12-08 14:13 ` Marcel Holtmann [this message]
2011-12-08 16:07 ` Philippe Nunes
2011-12-08 15:17 ` Marcel Holtmann
2011-12-08 16:50 ` Philippe Nunes
2011-12-09 12:09 ` Denis Kenzior
2011-12-08 14:49 ` [PATCH v2 07/12] huaweicdma: Use pcui port for cdma_netreg Philippe Nunes
2011-12-09 12:11 ` Denis Kenzior
2011-12-08 14:49 ` [PATCH v2 08/12] huaweicdma: Open qcdm port to be used for signal quality or network status Philippe Nunes
2011-12-08 14:50 ` [PATCH v2 09/12] huaweicdmamodem: Probe the QCDM port with the version info request Philippe Nunes
2011-12-08 14:50 ` [PATCH v2 10/12] huaweicdmamodem: Add 'serving_system' entry point to get SID Philippe Nunes
2011-12-08 14:50 ` [PATCH v2 11/12] udevng: Add a default assignment for Huawei QCDM port Philippe Nunes
2011-12-08 14:50 ` [PATCH v2 12/12] huaweicdmamodem: Fix sysinfo parsing Philippe Nunes
2011-12-09 12:14 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1323353603.1965.42.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox