Re: [PATCH_v0 2/3] huawei: Add modem type detection

[Marcel Holtmann <marcel@holtmann.org>]

[-- Attachment #1: Type: text/plain, Size: 2957 bytes --]

Hi Philippe,

> >>>
> >>>>
> >>>>    	DBG("%p", modem);
> >>>>
> >>>> -	ofono_devinfo_create(modem, 0, "atmodem", data->pcui);
> >>>> -	sim = ofono_sim_create(modem, OFONO_VENDOR_HUAWEI,
> >>>> +	if (data->gsm == TRUE) {
> >>>> +		ofono_devinfo_create(modem, 0, "atmodem", data->pcui);
> >>>> +		sim = ofono_sim_create(modem, OFONO_VENDOR_HUAWEI,
> >>>>    					"atmodem", data->pcui);
> >>>> +	} else {
> >>>> +		ofono_devinfo_create(modem, 0, "cdmamodem", data->pcui);
> >>>> +		/* Create sim atom only if sim is not embedded */
> >>>> +		if (data->sim_state != SIM_STATE_ROMSIM)
> >>>> +			sim = ofono_sim_create(modem, OFONO_VENDOR_HUAWEI,
> >>>> +						"atmodem", data->pcui);
> >>> I am really not sure that it is a good idea to just use the GSM SIM atom
> >>> here. The EF structure will be different and we might cause more harm
> >>> than doing any good in assuming that we get any proper EF fields.
> >>>
> >>> This is clearly the part where we need detailed information from Huawei
> >>> on how this is suppose to work. And how this is suppose to be done for
> >>> CDMA in the first place anyway.
> >>
> >> I agree, maybe Deng Yin An could ask Huawei how they (plan to) support
> >> R-UIM in their modem e.g.
> >> - Do they have some commands to read UIM file system
> >> - And what does ROMSIM consist in (differences against R-UIM)?
> >
> > Almost all CDMA modems in Chinese market support UIM/RUIM, including EC1261.
> > There're commands to check if UIM exists or ROMSIM exists.
> > The CDMA dongles support AT commands include those to touch SMS, address book,
> > the values includes field to see if it is from UIM/ROMSIM or NV inside dongle.
> > But I didn't see a command to touch raw FS directly.
> >
> >>
> 
> As previously indicated by Denis, the goal (if possible) is to use a 
> unified SIM atom for GSM and CDMA.
> So far, this should be possible as the R-UIM can be considered as an 
> extension of SIM (R-UIM 3GPP2 specification C.S0023).
> In practice, it is a matter of reading different EFs, while CHV/PIN 
> handling, BDN, FDN, etc are the same.
> 
> Actually, with the R-UIM capable CDMA dongles we have, the PIN 
> management appears to be exposed by standard AT commands (+CPIN, +CLCK). 
> However, this needs to be confirmed an documented by the manufacturers.
> Regarding FS reading/writing, this seems to be rather closed (at least 
> through AT commands).
> 
> My suggestion is to skip for now all EFs reading in case of R-UIM, and 
> support only the pin handling.
> We can also think to retrieve the IMSI even if this Id is actually not 
> mandatory for ConnMan (as the serial number is also considered).
> Are you OK with this first approach?

I fully agree with Denis, that a copy&paste of the SIM atom driver from
atmodem driver is not a good solution. So yes, check if the code can be
tweaked to make it work for CDMA as well.

Regards

Marcel