Open Source Telephony
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: ofono@ofono.org
Subject: Re: [PATCH] add some length verification to avoid reading not owned memory
Date: Mon, 27 Feb 2012 09:22:19 -0800	[thread overview]
Message-ID: <1330363339.3392.52.camel@aeonflux> (raw)
In-Reply-To: <4F4B4B0B.7060606@vfnet.de>

[-- Attachment #1: Type: text/plain, Size: 438 bytes --]

Hi Jens,

> while reading mmsd sources I stumbled over missing length
> checks in src/push.c:mms_push_notify(). I didn't re-read
> the entire source to prove overall ;)

please use git format-patch and git send-email to send us inline
patches. In case your email client doesn't support inline patches
nicely. Reviewing patches that are attached is super painful and in most
cases they get ignored then.

Regards

Marcel



  reply	other threads:[~2012-02-27 17:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-27  9:21 [PATCH] add some length verification to avoid reading not owned memory Jens Rehsack
2012-02-27 17:22 ` Marcel Holtmann [this message]
2012-02-28  8:30   ` Jens Rehsack
2012-02-28  2:38     ` Denis Kenzior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1330363339.3392.52.camel@aeonflux \
    --to=marcel@holtmann.org \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox