From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============5772934759662963396==" MIME-Version: 1.0 From: Marcel Holtmann Subject: Re: [PATCH v2] huawei: fix AT^DDSETEX=2 timing Date: Fri, 23 Mar 2012 21:14:26 -0700 Message-ID: <1332562466.1870.64.camel@aeonflux> In-Reply-To: <1332554761-30808-2-git-send-email-devel@jlranta.com> List-Id: To: ofono@ofono.org --===============5772934759662963396== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi Jarkko, > Voice output serial port is enabled on some Huawei models (e.g. E169) > without problems, but for example on E173u-2 it is never enabled > during an incoming call. There might also be other Huawei models > having the same issue. > = > I traced the issue down to "^DDSETEX" AT command, which is used > to notify the device to start streaming audio. It seems that Ofono > sends this command too early on incoming calls. The command should > always be sent *after* the dial "D" or answer "A" command. The patch > fixes this behavior and afterwards voice will also work on E173u-2. > = > Signed-off-by: Jarkko Lehtoranta > --- > drivers/huaweimodem/voicecall.c | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) Applying: huawei: fix AT^DDSETEX=3D2 timing /data/devel/ofono/.git/rebase-apply/patch:31: trailing whitespace. = /data/devel/ofono/.git/rebase-apply/patch:40: trailing whitespace. = /data/devel/ofono/.git/rebase-apply/patch:42: trailing whitespace. = fatal: 3 lines add whitespace errors. > diff --git a/drivers/huaweimodem/voicecall.c b/drivers/huaweimodem/voicec= all.c > index 1ea2613..3952b95 100644 > --- a/drivers/huaweimodem/voicecall.c > +++ b/drivers/huaweimodem/voicecall.c > @@ -78,9 +78,6 @@ static struct ofono_call *create_call(struct ofono_voic= ecall *vc, int type, > = > d->calls =3D g_slist_insert_sorted(d->calls, call, at_util_call_compare= ); > = > - g_at_chat_send(d->chat, "AT^DDSETEX=3D2", none_prefix, > - NULL, NULL, NULL); > - > return call; > } > = > @@ -117,6 +114,7 @@ static void huawei_dial(struct ofono_voicecall *vc, > ofono_voicecall_cb_t cb, void *data) > { > char buf[256]; > + struct voicecall_data *vd =3D ofono_voicecall_get_data(vc); Put this struct declaration first please. Regards Marcel --===============5772934759662963396==--