From: Marcel Holtmann <marcel@holtmann.org>
To: ofono@ofono.org
Subject: Re: [PATCH 2/3] Speedup: Use speedup specific driver for ussd
Date: Mon, 16 Apr 2012 19:02:34 +0200 [thread overview]
Message-ID: <1334595754.16897.177.camel@aeonflux> (raw)
In-Reply-To: <1334589023-3633-3-git-send-email-nicolas.bertrand@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1089 bytes --]
Hi Nicolas,
> plugins/speedup.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/plugins/speedup.c b/plugins/speedup.c
> index ca6ed13..8b95286 100644
> --- a/plugins/speedup.c
> +++ b/plugins/speedup.c
> @@ -2,7 +2,7 @@
> *
> * oFono - Open Source Telephony
> *
> - * Copyright (C) 2008-2011 Intel Corporation. All rights reserved.
> + * Copyright (C) 2008-2012 Intel Corporation. All rights reserved.
> *
> * This program is free software; you can redistribute it and/or modify
> * it under the terms of the GNU General Public License version 2 as
> @@ -282,8 +282,8 @@ static void speedup_post_online(struct ofono_modem *modem)
>
> ofono_cbs_create(modem, OFONO_VENDOR_QUALCOMM_MSM,
> "atmodem", data->aux);
> - ofono_ussd_create(modem, OFONO_VENDOR_QUALCOMM_MSM,
> - "atmodem", data->aux);
> + ofono_ussd_create(modem, OFONO_VENDOR_SPEEDUP,
> + "speedupmodem", data->aux);
you do not need both here. Either "speedupmodem" or OFONO_VENDOR_SPEEDUP
quirk.
Regards
Marcel
next prev parent reply other threads:[~2012-04-16 17:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-16 15:10 [PATCH 0/3] Speedup ussd driver Nicolas Bertrand
2012-04-16 15:10 ` [PATCH 1/3] Speedup: Add speedup driver to handle USSD Nicolas Bertrand
2012-04-16 18:17 ` Denis Kenzior
2012-04-16 15:10 ` [PATCH 2/3] Speedup: Use speedup specific driver for ussd Nicolas Bertrand
2012-04-16 17:02 ` Marcel Holtmann [this message]
2012-04-16 15:10 ` [PATCH 3/3] Makefile: Add speedup modem target Nicolas Bertrand
2012-04-16 18:18 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1334595754.16897.177.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox