Re: [PATCHv1 3/5] service: Fill conversation list with messages

[Marcel Holtmann <marcel@holtmann.org>]

[-- Attachment #1: Type: text/plain, Size: 1476 bytes --]

Hi Ronald,

> ---
>  src/service.c |   88 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
>  1 files changed, 87 insertions(+), 1 deletions(-)
> 
> diff --git a/src/service.c b/src/service.c
> index 18c11f4..2787c3a 100644
> --- a/src/service.c
> +++ b/src/service.c
> @@ -719,13 +719,85 @@ static gboolean get_conversation_get_args(DBusMessage *dbus_msg,
>  	return TRUE;
>  }
> 
> +static gboolean is_recipient(const char *recipients, const char *number)
> +{
> +	const char *rec, *num;
> +
> +	while (*recipients != '\0') {
> +		rec = recipients;
> +		num = number;
> +
> +		while (*rec != '\0' && *num != '\0') {
> +			if (*rec == *num) {
> +				rec++;
> +				num++;
> +			} else {
> +				if (*rec == '-' || *rec == '.') {
> +					rec++;
> +					continue;
> +				}
> +
> +				if (*num == '-' || *num == '.') {
> +					num++;
> +					continue;
> +				}
> +
> +				rec++;
> +				break;
> +			}
> +		}
> +
> +		/*
> +		 * Phone numbers in recipients end with /TYPE=PLMN, so the
> +		 * wanted number is found if the whole string number is found
> +		 * and if the matched phone number ends with the wanted number
> +		 * (i.e.: "/TYPE=PLMN" must follow).
> +		 */
> +		if (*num == '\0' && *rec == '/')
> +			return TRUE;
> +
> +		recipients = rec;
> +	}
> +
> +	return FALSE;
> +}

please explain what this function is actually doing? Adding a comment
seems like a good idea here.

Regards

Marcel