From mboxrd@z Thu Jan  1 00:00:00 1970
Content-Type: multipart/mixed; boundary="===============8915382556688480549=="
MIME-Version: 1.0
From: Marcel Holtmann <marcel@holtmann.org>
Subject: Re: [PATCH 3/3] doc: Add new D-Bus methods to service interface
Date: Thu, 07 Jun 2012 11:43:11 +0900
Message-ID: <1339036991.1817.118.camel@aeonflux>
In-Reply-To: <1338454376-12806-4-git-send-email-ronald.tessier@linux.intel.com>
List-Id: <ofono.ofono.org>
To: ofono@ofono.org

--===============8915382556688480549==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable

Hi Ronald,

>  doc/service-api.txt |   20 ++++++++++++++++++++
>  1 files changed, 20 insertions(+), 0 deletions(-)
> =

> diff --git a/doc/service-api.txt b/doc/service-api.txt
> index 36e1161..5c18cad 100644
> --- a/doc/service-api.txt
> +++ b/doc/service-api.txt
> @@ -63,6 +63,26 @@ Methods		array{object,dict} GetMessages()
>  				[service].Error.PermanentContentNotAccepted
>  				[service].Error.PermanentLackOfPrepaid
> =

> +		[TODO] void DeleteMessages(array{object})

I do not like the [TODO] annotation here. Left that out.

> +
> +			Delete an array of message objects that represents
> +			the currently stored messages to delete.
> +
> +			Possible Errors: [service].Error.InvalidArguments
> +
> +		[TODO] void DeleteConversation(string number)
> +
> +			Delete the messages that belongs to the conversation
> +			defined by the given number.
> +
> +			The number parameter contains digits to look for
> +			(i.e.: n last digits of the phone number), only messages
> +			with a recipient which ends with the given number will
> +			be member of the conversation and thus will be deleted.
> +
> +			Possible Errors: [service].Error.InvalidArguments
> +
> +
>  Signals		MessageAdded(object path, dict properties)
> =

>  			Signal that is sent when a new message is added. It

Regards

Marcel



--===============8915382556688480549==--