Open Source Telephony
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: ofono@ofono.org
Subject: Re: [PATCH 1/2] test-ussd becomes send-ussd
Date: Mon, 09 Jul 2012 13:39:29 -0300	[thread overview]
Message-ID: <1341851969.16443.0.camel@aeonflux> (raw)
In-Reply-To: <4FFB0629.9070304@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 867 bytes --]

Hi Denis,

> > ---
> >   test/send-ussd |   75 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >   test/test-ussd |   75 --------------------------------------------------------
> >   2 files changed, 75 insertions(+), 75 deletions(-)
> >   create mode 100755 test/send-ussd
> >   delete mode 100755 test/test-ussd
> >
> 
> Why don't we just get rid of test-ussd and create a new send-ussd script 
> that doesn't do any stdin handling.  Something along the lines of:
> 
> ss.GetProperties()
> 
> if state == 'idle'
> 	rsp = ss.Initiate()
> elif state == 'user-response'
> 	rsp = ss.Respond()
> 
> print response
> 
> And perhaps another ussd related script that just cancels the request. 
> Would this satisfy your requirements?

are the existing test/initiate-ussd and test/cancel-ussd not good
enough?

Regards

Marcel



  reply	other threads:[~2012-07-09 16:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-02 15:45 [PATCH 1/2] test-ussd becomes send-ussd Philippe Nunes
2012-07-02 15:45 ` [PATCH 2/2] test-ussd: new script more generic Philippe Nunes
2012-07-09 16:26 ` [PATCH 1/2] test-ussd becomes send-ussd Denis Kenzior
2012-07-09 16:39   ` Marcel Holtmann [this message]
2012-07-09 16:52     ` Denis Kenzior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1341851969.16443.0.camel@aeonflux \
    --to=marcel@holtmann.org \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox