From: Philippe Nunes <philippe.nunes@linux.intel.com>
To: ofono@ofono.org
Subject: [PATCH 5/8] call-barring: Return specific errors for SS query
Date: Wed, 22 Aug 2012 18:18:20 +0200 [thread overview]
Message-ID: <1345652303-12866-5-git-send-email-philippe.nunes@linux.intel.com> (raw)
In-Reply-To: <1345652303-12866-1-git-send-email-philippe.nunes@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 973 bytes --]
Trace is modified as a CB query is not necessarily done after a CB setting
via SS.
---
src/call-barring.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/src/call-barring.c b/src/call-barring.c
index 53847fb..68533c2 100644
--- a/src/call-barring.c
+++ b/src/call-barring.c
@@ -284,14 +284,13 @@ static void cb_ss_query_next_lock_callback(const struct ofono_error *error,
struct ofono_call_barring *cb = data;
if (error->type != OFONO_ERROR_TYPE_NO_ERROR) {
- if (cb->ss_req_type != SS_CONTROL_TYPE_QUERY)
- ofono_error("Enabling/disabling Call Barring via SS "
- "successful, but query was not");
+ ofono_error("Query failed with error: %s",
+ telephony_error_to_str(error));
cb->flags &= ~CALL_BARRING_FLAG_CACHED;
__ofono_dbus_pending_reply(&cb->pending,
- __ofono_error_failed(cb->pending));
+ __ofono_error_from_error(error, cb->pending));
return;
}
--
1.7.9.5
next prev parent reply other threads:[~2012-08-22 16:18 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-22 16:18 [PATCH 1/8] ussd: Recover idle state in case of response sending failure Philippe Nunes
2012-08-22 16:18 ` [PATCH 2/8] stkagent: '+' is considered as a digit Philippe Nunes
2012-08-22 22:55 ` Denis Kenzior
2012-08-23 15:53 ` Philippe Nunes
2012-08-23 18:15 ` Denis Kenzior
2012-08-22 16:18 ` [PATCH 3/8] call-forwarding: return specific errors for SS query Philippe Nunes
2012-08-22 23:18 ` Denis Kenzior
2012-08-22 16:18 ` [PATCH 4/8] call-forwarding: class applied is the class given by SS code Philippe Nunes
2012-08-22 23:36 ` Denis Kenzior
2012-08-23 15:30 ` Philippe Nunes
2012-08-23 18:32 ` Denis Kenzior
2012-08-22 16:18 ` Philippe Nunes [this message]
2012-08-22 23:19 ` [PATCH 5/8] call-barring: Return specific errors for SS query Denis Kenzior
2012-08-22 16:18 ` [PATCH 6/8] call-barring: class applied is the class given by SS code Philippe Nunes
2012-08-22 16:18 ` [PATCH 7/8] call-settings: Return specific errors for SS query Philippe Nunes
2012-08-22 23:19 ` Denis Kenzior
2012-08-22 16:18 ` [PATCH 8/8] call-settings: class applied is the class given by SS code Philippe Nunes
2012-08-22 23:41 ` Denis Kenzior
2012-08-22 23:02 ` [PATCH 1/8] ussd: Recover idle state in case of response sending failure Denis Kenzior
2012-08-23 10:30 ` Philippe Nunes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1345652303-12866-5-git-send-email-philippe.nunes@linux.intel.com \
--to=philippe.nunes@linux.intel.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox