Open Source Telephony
 help / color / mirror / Atom feed
From: Philippe Nunes <philippe.nunes@linux.intel.com>
To: ofono@ofono.org
Subject: [PATCH 0/4] DTMF in dialing number
Date: Wed, 05 Sep 2012 19:19:35 +0200	[thread overview]
Message-ID: <1346865579-24794-1-git-send-email-philippe.nunes@linux.intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1213 bytes --]

GCF test cases unveiled the following requirements not currently
supported by oFono:

- Dialing number provided by Setup Call can include a pause character
followed by a DTMF string.

I noticed that DTMFs concatenated to the dialing number are likely to be
handled directly by the modem. So, I suggest to include the pause character
as an acceptable digit in the phone number.

- Dialing number provided by Setup Call can be greater than 20 digits.

- AID shall not be displayed in case of self explanatory icon
As I'm not sure if it is intended to not take into account this icon qualifier
I just implemented a fix in stk.c
If you agree with this requirement, then we would need to check the icon
qualifier in each Stkagent method.

Philippe.

Philippe Nunes (4):
  stk: convert to phone number format
  common: Accept pause character in the dialing number
  voicecall: Accept long phone number format for STK
  stk: AID shall not be displayed in case of self explanatory icon

 src/common.c    |    2 +-
 src/stk.c       |   55 ++++++++++++++++++++++++++++++++++++++++---------------
 src/voicecall.c |    2 +-
 3 files changed, 42 insertions(+), 17 deletions(-)

-- 
1.7.9.5


             reply	other threads:[~2012-09-05 17:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-05 17:19 Philippe Nunes [this message]
2012-09-05 17:19 ` [PATCH 1/4] stk: convert to phone number format Philippe Nunes
2012-09-05 17:19 ` [PATCH 2/4] common: Accept pause character in the dialing number Philippe Nunes
2012-09-05 19:25   ` Denis Kenzior
2012-09-05 17:19 ` [PATCH 3/4] voicecall: Accept long phone number format for STK Philippe Nunes
2012-09-05 19:26   ` Denis Kenzior
2012-09-05 17:19 ` [PATCH 4/4] stk: AID shall not be displayed in case of self explanatory icon Philippe Nunes
2012-09-05 19:29   ` Denis Kenzior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1346865579-24794-1-git-send-email-philippe.nunes@linux.intel.com \
    --to=philippe.nunes@linux.intel.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox