Open Source Telephony
 help / color / mirror / Atom feed
From: Anthony Viallard <viallard@syscom-instruments.com>
To: ofono@ofono.org
Subject: [PATCH 2/6] SIMCOM: add a quirk for AT+CNMI command building.
Date: Fri, 19 Jul 2013 15:35:36 +0200	[thread overview]
Message-ID: <1374240940-30892-2-git-send-email-viallard@syscom-instruments.com> (raw)
In-Reply-To: <1374240940-30892-1-git-send-email-viallard@syscom-instruments.com>

[-- Attachment #1: Type: text/plain, Size: 638 bytes --]

Use mode=1 otherwise it fails (ref. "SIM5215_SIM5216_ATC_V1.18.pdf - §6.9")
---
 drivers/atmodem/sms.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/atmodem/sms.c b/drivers/atmodem/sms.c
index fde90ba..f93dd23 100644
--- a/drivers/atmodem/sms.c
+++ b/drivers/atmodem/sms.c
@@ -805,6 +805,7 @@ static gboolean build_cnmi_string(char *buf, int *cnmi_opts,
 	case OFONO_VENDOR_NOVATEL:
 	case OFONO_VENDOR_HUAWEI:
 	case OFONO_VENDOR_ZTE:
+	case OFONO_VENDOR_SIMCOM:
 		/* MSM devices advertise support for mode 2, but return an
 		 * error if we attempt to actually use it. */
 		mode = "1";
-- 
1.8.3.1


  reply	other threads:[~2013-07-19 13:35 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-19 13:35 [PATCH 1/6] Add SIMCOM support Anthony Viallard
2013-07-19 13:35 ` Anthony Viallard [this message]
2013-07-22 20:49   ` [PATCH 2/6] SIMCOM: add a quirk for AT+CNMI command building Denis Kenzior
2013-07-19 13:35 ` [PATCH 3/6] SIMCOM: add a quirk for signal strength reporting Anthony Viallard
2013-07-22 20:49   ` Denis Kenzior
2013-07-19 13:35 ` [PATCH 4/6] SIMCOM: add a quirk to fix crsm request Anthony Viallard
2013-07-22 20:51   ` Denis Kenzior
2013-07-19 13:35 ` [PATCH 5/6] Add a function to be able to report network technology change Anthony Viallard
2013-07-22 20:57   ` Denis Kenzior
2013-07-19 13:35 ` [PATCH 6/6] SIMCOM: add a quirk to retrieve network technology used Anthony Viallard
2013-07-22 21:08   ` Denis Kenzior
2013-07-22 20:45 ` [PATCH 1/6] Add SIMCOM support Denis Kenzior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1374240940-30892-2-git-send-email-viallard@syscom-instruments.com \
    --to=viallard@syscom-instruments.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox