[PATCH] qmi: gprs-context: Actually send param to qmi_service_send

[PATCH] qmi: gprs-context: Actually send param to qmi_service_send

[Denis Kenzior]

The parameter structure was built, but not included into the
qmi_service_send call resulting in a memory leak.

Fixes: b6ced6c5c4c9 ("qmi: gprs-context: Request certain TLVs to be included")
---
 drivers/qmimodem/gprs-context.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/qmimodem/gprs-context.c b/drivers/qmimodem/gprs-context.c
index 055378dc102f..4004876bab87 100644
--- a/drivers/qmimodem/gprs-context.c
+++ b/drivers/qmimodem/gprs-context.c
@@ -194,7 +194,7 @@ static void start_net_cb(struct qmi_result *result, void *user_data)
 	param = qmi_param_new_uint32(PARAM_REQUESTED_SETTINGS,
 						requested_settings);
 
-	if (qmi_service_send(data->wds, QMI_WDS_GET_CURRENT_SETTINGS, NULL,
+	if (qmi_service_send(data->wds, QMI_WDS_GET_CURRENT_SETTINGS, param,
 				get_settings_cb, cbd, cb_data_unref) > 0) {
 		cb_data_ref(cbd);
 		return;
-- 
2.44.0

Re: [PATCH] qmi: gprs-context: Actually send param to qmi_service_send

[patchwork-bot+ofono]

Hello:

This patch was applied to ofono.git (master)
by Denis Kenzior <denkenz@gmail.com>:

On Thu, 25 Apr 2024 15:11:14 -0500 you wrote:
> The parameter structure was built, but not included into the
> qmi_service_send call resulting in a memory leak.
> 
> Fixes: b6ced6c5c4c9 ("qmi: gprs-context: Request certain TLVs to be included")
> ---
>  drivers/qmimodem/gprs-context.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
  - qmi: gprs-context: Actually send param to qmi_service_send
    https://git.kernel.org/pub/scm/network/ofono/ofono.git/?id=06978a863b4d

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html