* [PATCH 0/3] add support for Quectel EG916Q-GL
@ 2024-09-10 7:22 Benjamin B. Frost
2024-09-10 7:22 ` [PATCH 1/3] udevng: support for EG916Q-GL using option driver Benjamin B. Frost
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Benjamin B. Frost @ 2024-09-10 7:22 UTC (permalink / raw)
To: ofono; +Cc: sean, martin, denkenz, Benjamin B. Frost
The aim for this patchset is to add support for quectel EG916Q-GL
using the usb serial port.
Benjamin B. Frost (3):
udevng: support for EG916Q-GL using option driver.
quectel: support for EG916Q-GL
atmodem: Support for Quectel EG916Q-GL modem
drivers/atmodem/gprs-context.c | 3 +++
drivers/atmodem/gprs.c | 1 +
drivers/atmodem/network-registration.c | 1 +
drivers/atmodem/sim.c | 1 +
drivers/atmodem/sms.c | 2 ++
drivers/atmodem/vendor.h | 1 +
plugins/quectel.c | 10 +++++++++-
plugins/udevng.c | 4 +++-
8 files changed, 21 insertions(+), 2 deletions(-)
--
2.34.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/3] udevng: support for EG916Q-GL using option driver.
2024-09-10 7:22 [PATCH 0/3] add support for Quectel EG916Q-GL Benjamin B. Frost
@ 2024-09-10 7:22 ` Benjamin B. Frost
2024-09-10 7:22 ` [PATCH 2/3] quectel: support for EG916Q-GL Benjamin B. Frost
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Benjamin B. Frost @ 2024-09-10 7:22 UTC (permalink / raw)
To: ofono; +Cc: sean, martin, denkenz, Benjamin B. Frost
add Quectel EG916Q-GL with product id 0x6007 to vendor list
---
plugins/udevng.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/plugins/udevng.c b/plugins/udevng.c
index 1c56e2ea..f4266f39 100644
--- a/plugins/udevng.c
+++ b/plugins/udevng.c
@@ -1045,7 +1045,8 @@ static gboolean setup_quectel_usb(struct modem_info *modem)
mdm = info->devnode;
if (aux != NULL)
break;
- } else if (g_strcmp0(info->interface, "255/255/255") == 0) {
+ } else if (g_strcmp0(info->interface, "255/255/255") == 0 ||
+ g_strcmp0(info->interface, "255/0/0") == 0) {
if (g_strcmp0(info->number, "02") == 0)
aux = info->devnode;
else if (g_strcmp0(info->number, "03") == 0)
@@ -2145,6 +2146,7 @@ static struct {
{ "samsung", "option", "04e8", "6889" },
{ "samsung", "kalmia" },
{ "quectel", "option", "05c6", "9090" },
+ { "quectel", "option", "2c7c", "6007" },
{ "quectelqmi", "qmi_wwan", "2c7c", "0121" },
{ "quectelqmi", "qcserial", "2c7c", "0121" },
{ "quectelqmi", "qmi_wwan", "2c7c", "0125" },
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/3] quectel: support for EG916Q-GL
2024-09-10 7:22 [PATCH 0/3] add support for Quectel EG916Q-GL Benjamin B. Frost
2024-09-10 7:22 ` [PATCH 1/3] udevng: support for EG916Q-GL using option driver Benjamin B. Frost
@ 2024-09-10 7:22 ` Benjamin B. Frost
2024-09-10 7:22 ` [PATCH 3/3] atmodem: Support for Quectel EG916Q-GL modem Benjamin B. Frost
2024-09-11 1:00 ` [PATCH 0/3] add support for Quectel EG916Q-GL patchwork-bot+ofono
3 siblings, 0 replies; 5+ messages in thread
From: Benjamin B. Frost @ 2024-09-10 7:22 UTC (permalink / raw)
To: ofono; +Cc: sean, martin, denkenz, Benjamin B. Frost
add support for Quectel EG916Q-GL
---
plugins/quectel.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/plugins/quectel.c b/plugins/quectel.c
index cee802d7..72827097 100644
--- a/plugins/quectel.c
+++ b/plugins/quectel.c
@@ -50,7 +50,7 @@ static const char *cfun_prefix[] = { "+CFUN:", NULL };
static const char *cpin_prefix[] = { "+CPIN:", NULL };
static const char *cbc_prefix[] = { "+CBC:", NULL };
static const char *qinistat_prefix[] = { "+QINISTAT:", NULL };
-static const char *cgmm_prefix[] = { "UC15", "Quectel_M95", "Quectel_MC60",
+static const char *cgmm_prefix[] = { "UC15", "Quectel_M95", "EG916Q-GL", "Quectel_MC60",
"EC21", "EC200", NULL };
static const char *none_prefix[] = { NULL };
@@ -69,6 +69,7 @@ enum quectel_model {
QUECTEL_UNKNOWN,
QUECTEL_UC15,
QUECTEL_M95,
+ QUECTEL_EG916Q,
QUECTEL_MC60,
QUECTEL_EC21,
QUECTEL_EC200,
@@ -120,6 +121,7 @@ static ofono_bool_t quectel_model_supports_lte(enum quectel_model model)
switch (model) {
case QUECTEL_EC21:
case QUECTEL_EC200:
+ case QUECTEL_EG916Q:
return TRUE;
default:
return FALSE;
@@ -556,6 +558,7 @@ static void dbus_hw_enable(struct ofono_modem *modem)
NULL);
break;
case QUECTEL_M95:
+ case QUECTEL_EG916Q:
case QUECTEL_MC60:
g_at_chat_register(data->aux, "OVER_VOLTAGE POWER DOWN",
power_notify, FALSE, hw, NULL);
@@ -597,6 +600,7 @@ static void qinistat_cb(gboolean ok, GAtResult *result, gpointer user_data)
switch (data->model) {
case QUECTEL_UC15:
case QUECTEL_EC21:
+ case QUECTEL_EG916Q:
/* UC15 uses a bitmap of 1 + 2 + 4 = 7 */
ready = 7;
break;
@@ -865,6 +869,10 @@ static void cgmm_cb(int ok, GAtResult *result, void *user_data)
DBG("%p model M95", modem);
data->vendor = OFONO_VENDOR_QUECTEL_SERIAL;
data->model = QUECTEL_M95;
+ } else if (strcmp(model, "EG916Q-GL") == 0) {
+ DBG("%p model EG916Q-GL", modem);
+ data->vendor = OFONO_VENDOR_QUECTEL_EG91X;
+ data->model = QUECTEL_EG916Q;
} else if (strcmp(model, "Quectel_MC60") == 0) {
DBG("%p model MC60", modem);
data->vendor = OFONO_VENDOR_QUECTEL_SERIAL;
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 3/3] atmodem: Support for Quectel EG916Q-GL modem
2024-09-10 7:22 [PATCH 0/3] add support for Quectel EG916Q-GL Benjamin B. Frost
2024-09-10 7:22 ` [PATCH 1/3] udevng: support for EG916Q-GL using option driver Benjamin B. Frost
2024-09-10 7:22 ` [PATCH 2/3] quectel: support for EG916Q-GL Benjamin B. Frost
@ 2024-09-10 7:22 ` Benjamin B. Frost
2024-09-11 1:00 ` [PATCH 0/3] add support for Quectel EG916Q-GL patchwork-bot+ofono
3 siblings, 0 replies; 5+ messages in thread
From: Benjamin B. Frost @ 2024-09-10 7:22 UTC (permalink / raw)
To: ofono; +Cc: sean, martin, denkenz, Benjamin B. Frost
---
drivers/atmodem/gprs-context.c | 3 +++
drivers/atmodem/gprs.c | 1 +
drivers/atmodem/network-registration.c | 1 +
drivers/atmodem/sim.c | 1 +
drivers/atmodem/sms.c | 2 ++
drivers/atmodem/vendor.h | 1 +
6 files changed, 9 insertions(+)
diff --git a/drivers/atmodem/gprs-context.c b/drivers/atmodem/gprs-context.c
index da63fa1c..7d4bd094 100644
--- a/drivers/atmodem/gprs-context.c
+++ b/drivers/atmodem/gprs-context.c
@@ -455,6 +455,9 @@ static int at_gprs_context_probe(struct ofono_gprs_context *gc,
case OFONO_VENDOR_SIMCOM_SIM900:
gcd->use_atd99 = FALSE;
break;
+ case OFONO_VENDOR_QUECTEL_EG91X:
+ gcd->use_atd99 = TRUE;
+ break;
default:
g_at_chat_send(chat, "AT+CGDATA=?", cgdata_prefix,
at_cgdata_test_cb, gc, NULL);
diff --git a/drivers/atmodem/gprs.c b/drivers/atmodem/gprs.c
index fa82878c..37b67405 100644
--- a/drivers/atmodem/gprs.c
+++ b/drivers/atmodem/gprs.c
@@ -668,6 +668,7 @@ static void gprs_initialized(gboolean ok, GAtResult *result, gpointer user_data)
NULL, NULL, NULL);
break;
case OFONO_VENDOR_QUECTEL_EC2X:
+ case OFONO_VENDOR_QUECTEL_EG91X:
case OFONO_VENDOR_QUECTEL_SERIAL:
break;
default:
diff --git a/drivers/atmodem/network-registration.c b/drivers/atmodem/network-registration.c
index b7a66c4d..46b8512a 100644
--- a/drivers/atmodem/network-registration.c
+++ b/drivers/atmodem/network-registration.c
@@ -2103,6 +2103,7 @@ static void at_creg_set_cb(gboolean ok, GAtResult *result, gpointer user_data)
/* Signal strength reporting via CIND is not supported */
break;
case OFONO_VENDOR_QUECTEL_EC2X:
+ case OFONO_VENDOR_QUECTEL_EG91X:
g_at_chat_register(nd->chat, "+QIND:",
quectel_qind_notify, FALSE, netreg, NULL);
/* Register for specific signal strength reports */
diff --git a/drivers/atmodem/sim.c b/drivers/atmodem/sim.c
index 9eb29cc0..809d405d 100644
--- a/drivers/atmodem/sim.c
+++ b/drivers/atmodem/sim.c
@@ -1211,6 +1211,7 @@ static void at_pin_retries_query(struct ofono_sim *sim,
break;
case OFONO_VENDOR_QUECTEL:
case OFONO_VENDOR_QUECTEL_EC2X:
+ case OFONO_VENDOR_QUECTEL_EG91X:
if (g_at_chat_send(sd->chat, "AT+QPINC?", qpinc_prefix,
at_qpinc_cb, cbd, g_free) > 0)
return;
diff --git a/drivers/atmodem/sms.c b/drivers/atmodem/sms.c
index 34968d9a..d994856b 100644
--- a/drivers/atmodem/sms.c
+++ b/drivers/atmodem/sms.c
@@ -324,6 +324,7 @@ static inline void at_ack_delivery(struct ofono_sms *sms)
switch (data->vendor) {
case OFONO_VENDOR_GEMALTO:
case OFONO_VENDOR_QUECTEL_EC2X:
+ case OFONO_VENDOR_QUECTEL_EG91X:
snprintf(buf, sizeof(buf), "AT+CNMA=1");
break;
case OFONO_VENDOR_QUECTEL_SERIAL:
@@ -835,6 +836,7 @@ static gboolean build_cnmi_string(char *buf, int *cnmi_opts,
case OFONO_VENDOR_SIMCOM_A76XX:
case OFONO_VENDOR_QUECTEL:
case OFONO_VENDOR_QUECTEL_EC2X:
+ case OFONO_VENDOR_QUECTEL_EG91X:
case OFONO_VENDOR_DROID:
/* MSM devices advertise support for mode 2, but return an
* error if we attempt to actually use it. */
diff --git a/drivers/atmodem/vendor.h b/drivers/atmodem/vendor.h
index 20768832..faceede1 100644
--- a/drivers/atmodem/vendor.h
+++ b/drivers/atmodem/vendor.h
@@ -33,6 +33,7 @@ enum ofono_vendor {
OFONO_VENDOR_ALCATEL,
OFONO_VENDOR_QUECTEL,
OFONO_VENDOR_QUECTEL_EC2X,
+ OFONO_VENDOR_QUECTEL_EG91X,
OFONO_VENDOR_QUECTEL_SERIAL,
OFONO_VENDOR_UBLOX,
OFONO_VENDOR_XMM,
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 0/3] add support for Quectel EG916Q-GL
2024-09-10 7:22 [PATCH 0/3] add support for Quectel EG916Q-GL Benjamin B. Frost
` (2 preceding siblings ...)
2024-09-10 7:22 ` [PATCH 3/3] atmodem: Support for Quectel EG916Q-GL modem Benjamin B. Frost
@ 2024-09-11 1:00 ` patchwork-bot+ofono
3 siblings, 0 replies; 5+ messages in thread
From: patchwork-bot+ofono @ 2024-09-11 1:00 UTC (permalink / raw)
To: Benjamin B. Frost; +Cc: ofono, sean, martin, denkenz
Hello:
This series was applied to ofono.git (master)
by Denis Kenzior <denkenz@gmail.com>:
On Tue, 10 Sep 2024 09:22:07 +0200 you wrote:
> The aim for this patchset is to add support for quectel EG916Q-GL
> using the usb serial port.
>
> Benjamin B. Frost (3):
> udevng: support for EG916Q-GL using option driver.
> quectel: support for EG916Q-GL
> atmodem: Support for Quectel EG916Q-GL modem
>
> [...]
Here is the summary with links:
- [1/3] udevng: support for EG916Q-GL using option driver.
https://git.kernel.org/pub/scm/network/ofono/ofono.git/?id=ef867dce8f01
- [2/3] quectel: support for EG916Q-GL
https://git.kernel.org/pub/scm/network/ofono/ofono.git/?id=e9af32a90215
- [3/3] atmodem: Support for Quectel EG916Q-GL modem
https://git.kernel.org/pub/scm/network/ofono/ofono.git/?id=87b12433cbca
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-09-11 1:00 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-10 7:22 [PATCH 0/3] add support for Quectel EG916Q-GL Benjamin B. Frost
2024-09-10 7:22 ` [PATCH 1/3] udevng: support for EG916Q-GL using option driver Benjamin B. Frost
2024-09-10 7:22 ` [PATCH 2/3] quectel: support for EG916Q-GL Benjamin B. Frost
2024-09-10 7:22 ` [PATCH 3/3] atmodem: Support for Quectel EG916Q-GL modem Benjamin B. Frost
2024-09-11 1:00 ` [PATCH 0/3] add support for Quectel EG916Q-GL patchwork-bot+ofono
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox