From: patchwork-bot+ofono@kernel.org
To: Sicelo A. Mhlongo <absicsz@gmail.com>
Cc: ofono@lists.linux.dev
Subject: Re: [PATCH] smsutil: fix possible buffer overflow
Date: Thu, 10 Apr 2025 03:30:32 +0000 [thread overview]
Message-ID: <174425583201.3136865.16589582099784143392.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20250407215308.9674-1-absicsz@gmail.com>
Hello:
This patch was applied to ofono.git (master)
by Denis Kenzior <denkenz@gmail.com>:
On Mon, 7 Apr 2025 23:52:50 +0200 you wrote:
> Adding the null terminator is not necessary since encode_hex_own_address()
> already provides it. The bug was discovered via ASAN:
>
> ==2244==ERROR: AddressSanitizer: stack-buffer-overflow on address 0xffffa141b839 at pc 0x0000008d2ac0 bp 0xfffffea95f00 sp 0xfffffea95f18
> WRITE of size 1 at 0xffffa141b839 thread T0
> #0 0x8d2abc in sms_address_to_hex_string src/smsutil.c:2418
> #1 0x8d3ac0 in sms_assembly_store src/smsutil.c:2509
> #2 0x8d5fdc in sms_assembly_add_fragment_backup src/smsutil.c:2696
> #3 0x8d4bb8 in sms_assembly_add_fragment src/smsutil.c:2603
> #4 0x88c10c in handle_deliver src/sms.c:1442
> #5 0x88cff4 in ofono_sms_deliver_notify src/sms.c:1638
> #6 0x58b7ac in raw_read_cb drivers/qmimodem/sms.c:403
> #7 0x55e6cc in service_send_callback drivers/qmimodem/qmi.c:2476
> #8 0x549fc4 in __rx_message drivers/qmimodem/qmi.c:801
> #9 0x54cfdc in received_qmux_data drivers/qmimodem/qmi.c:1043
> #10 0xaad880 in io_callback ell/io.c:105
> #11 0xaa7e1c in l_main_iterate ell/main.c:461
> #12 0x807958 in event_check src/main.c:182
> #13 0xffffa3fdf964 (/lib/aarch64-linux-gnu/libglib-2.0.so.0+0x5f964) (BuildId: 3901bdcbc847d04fc971a1923bed26ef7d9b81e4)
> #14 0xffffa3fe03b4 (/lib/aarch64-linux-gnu/libglib-2.0.so.0+0x603b4) (BuildId: 3901bdcbc847d04fc971a1923bed26ef7d9b81e4)
> #15 0xffffa3fe10e0 in g_main_loop_run (/lib/aarch64-linux-gnu/libglib-2.0.so.0+0x610e0) (BuildId: 3901bdcbc847d04fc971a1923bed26ef7d9b81e4)
> #16 0x808478 in main src/main.c:300
> #17 0xffffa36f2298 (/lib/aarch64-linux-gnu/libc.so.6+0x22298) (BuildId: 8e356c2fd2ec1ebf5535228f366e2af8bd837770)
> #18 0xffffa36f2378 in __libc_start_main (/lib/aarch64-linux-gnu/libc.so.6+0x22378) (BuildId: 8e356c2fd2ec1ebf5535228f366e2af8bd837770)
> #19 0x41096c in _start (/home/mobian/ofono/src/ofonod+0x41096c) (BuildId: e672292c782b5f428bf5870e0142347fe81107b2)
>
> [...]
Here is the summary with links:
- smsutil: fix possible buffer overflow
https://git.kernel.org/pub/scm/network/ofono/ofono.git/?id=9e9c1cb58334
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2025-04-10 3:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-07 21:52 [PATCH] smsutil: fix possible buffer overflow Sicelo A. Mhlongo
2025-04-10 3:30 ` patchwork-bot+ofono [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174425583201.3136865.16589582099784143392.git-patchwork-notify@kernel.org \
--to=patchwork-bot+ofono@kernel.org \
--cc=absicsz@gmail.com \
--cc=ofono@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox