Open Source Telephony
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH] Make SimManager property SubscriberNumbers writable.
Date: Fri, 07 Aug 2009 15:52:43 -0500	[thread overview]
Message-ID: <200908071552.43740.denkenz@gmail.com> (raw)
In-Reply-To: <1249590572-18743-1-git-send-email-andrew.zaborowski@intel.com>

[-- Attachment #1: Type: text/plain, Size: 770 bytes --]

Hi Andrew,

> This implements writing SubscriberNumbers if the SIM allows this (optional
> to the SIM provider).  Because the property is an array of phone numbers,
> setting the property needs to write multiple records on the SIM so it's not
> atomic and potentially can fail partially.  In this case we have to report
> a write error to DBus client but at the same time file may be changed and
> we send a PropertyChanged.

I applied he patch but made some fixes.  Namely you can set the subscriber 
number array to any value with number of elements 0 .. # of records in 
EFmsisdn.

I also fixed sim_adn_parse/sim_adn_build functions to report the TON properly.

Can you do some more testing to make sure it is working as intended?

Regards,
-Denis

      parent reply	other threads:[~2009-08-07 20:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-06 20:29 [PATCH] Make SimManager property SubscriberNumbers writable Andrzej Zaborowski
2009-08-07  9:24 ` Andrzej Zaborowski
2009-08-07 20:52 ` Denis Kenzior [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200908071552.43740.denkenz@gmail.com \
    --to=denkenz@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox