Open Source Telephony
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH] [RFC] Do the PIN check in SIMManager
Date: Tue, 22 Sep 2009 00:12:29 -0500	[thread overview]
Message-ID: <200909220012.29847.denkenz@gmail.com> (raw)
In-Reply-To: <fb249edb0909171157w3b00b220o2538793c09016d81@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 760 bytes --]

Hi Andrew,

> And here's a version that implements most of what's specified in
> doc/sim-api.txt.  There are two caveats: when you re-enable SIM PIN

Patch has been applied, thanks.

> authentication, you have to give the old password from before it was
> changed to "", i.e to disable and enable SIM PIN, do:
> SimManager.ChangePin("pin", "1234", "")
> SimManager.ChangePin("pin", "1234", "1234")
>
> rather than the more logical
>
> SimManager.ChangePin("pin", "1234", "")
> SimManager.ChangePin("pin, "", "1234)
>
> The other problem is that if changing the password succeeds but
> enabling authentiation fails, ChangePin still returns failure

I added LockPin and UnlockPin methods to take care of these two cases.

Regards,
-Denis

  reply	other threads:[~2009-09-22  5:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-05  7:25 [PATCH] [RFC] Do the PIN check in SIMManager Andrzej Zaborowski
2009-09-07  9:53 ` Santtu Lakkala
2009-09-08  2:41   ` Andrzej Zaborowski
2009-09-17 18:57     ` Andrzej Zaborowski
2009-09-22  5:12       ` Denis Kenzior [this message]
2009-09-23 20:47         ` andrzej zaborowski
2009-09-23 20:02           ` Denis Kenzior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200909220012.29847.denkenz@gmail.com \
    --to=denkenz@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox