Hi Ryan, > > You're blowing away the result of cfmakeraw. Most of the devices are not > > true serial devices and so do not need any of the special options. > > Passing a NULL options GHashTable should result in cfmakeraw. Why don't > > you just pass all the options you need instead of using tcgetattr? > > Should i just move the tcgetattr() to happen before cfmakeraw()? Only one (executed last) will have effect, and I want it to be the cfmakeraw. So simply get rid of tcgetattr. > > > The other parts of the patch look good to me. > > Ok. Why don't i just add the string options ("read", others...) in > gattty.c? This is what I would prefer. Regards, -Denis