Open Source Telephony
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [RFC] GPRS context setup and teardown (doc/dataconnectionmanager-api.txt)
Date: Sat, 24 Oct 2009 12:37:32 -0500	[thread overview]
Message-ID: <200910241237.32751.denkenz@gmail.com> (raw)
In-Reply-To: <fb249edb0910240118h21bb3464ya8b655ae4db9aba0@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 776 bytes --]

Hi Andrew,

> 2009/10/24 andrzej zaborowski <balrogg@gmail.com>:
> > 2009/10/24 Denis Kenzior <denkenz@gmail.com>:
> >> Ok, so I took the patch and hacked on it for a while.  I disagreed with
> >> how you split up responsibilities, so much of the logic got moved into
> >> the core and the driver was simplified.
>
> By the way I notice that in most atoms' _create functions, when we
> loop over the drivers
> and call drv->probe() until we succeed, we still return success even if
> none of the drivers succeeded, should we return a NULL?

I think my intention was to eventually have foo_driver_register functions also 
go through the probe process.  Without the driver the atoms are never 
registered, so the way it is now is OK for now.

Regards,
-Denis

  reply	other threads:[~2009-10-24 17:37 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-12 21:35 [RFC] GPRS context setup and teardown (doc/dataconnectionmanager-api.txt) Andrzej Zaborowski
2009-10-12 20:01 ` Andrzej Zaborowski
2009-10-16 18:23   ` Denis Kenzior
2009-10-23 22:22 ` Denis Kenzior
2009-10-24  8:04   ` andrzej zaborowski
2009-10-24  8:18     ` Andrzej Zaborowski
2009-10-24 17:37       ` Denis Kenzior [this message]
2009-10-24 15:30     ` Denis Kenzior
2009-10-25  0:02       ` andrzej zaborowski
2009-10-25  3:43         ` Denis Kenzior
2009-10-25  6:39           ` andrzej zaborowski
2009-10-25  6:43             ` andrzej zaborowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200910241237.32751.denkenz@gmail.com \
    --to=denkenz@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox