From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 2/2] Altered the atgeneric modem to include the added modem.conf options.
Date: Thu, 29 Oct 2009 11:25:06 -0500 [thread overview]
Message-ID: <200910291125.06961.denkenz@gmail.com> (raw)
In-Reply-To: <632f5f310910270555r653f80b0m7b0009991664f55b@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 612 bytes --]
Hi Ryan,
> The modem.conf options for the driver portion of the patch.
Patch has been applied with some refactoring afterward. I know you ran
checkpatch.pl, but please make sure you follow the coding standard even for
parts which checkpatch.pl does not catch. In particular:
> +static const char *tty_opts[] =
> + {
> + "Baud",
> + "Read",
> + "Local",
> + "StopBits",
> + "DataBits",
> + "Parity",
> + "XonXoff",
> + "Rtscts",
> + NULL,
> + };
- There are spaces for indentation, ONLY tabs should be used.
- The opening brace should be on the tty_opts line.
next prev parent reply other threads:[~2009-10-29 16:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-27 12:55 [PATCH 2/2] Altered the atgeneric modem to include the added modem.conf options Ryan Raasch
2009-10-29 16:25 ` Denis Kenzior [this message]
2009-10-29 16:29 ` Ryan Raasch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200910291125.06961.denkenz@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox