From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH] Properly skip over quoted values
Date: Tue, 10 Nov 2009 12:54:01 -0600 [thread overview]
Message-ID: <200911101254.01405.denkenz@gmail.com> (raw)
In-Reply-To: <1257834691-22584-1-git-send-email-andrew.zaborowski@intel.com>
[-- Attachment #1: Type: text/plain, Size: 432 bytes --]
Hi Andrew,
> Otherwise a left paren in a string can bring an obscure segfault.
> ---
> + if (line[i] == '\"') {
> + i += 1;
> + while (i < len && line[i] != '\"')
> + i += 1;
> +
> + if (i < len)
> + i += 1;
> +
> + continue;
> + }
> +
I suggest you recursively call skip_until here instead of duplicating the
code. It also should be moved down and treated like '(' and ')'
Regards,
-Denis
next prev parent reply other threads:[~2009-11-10 18:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-10 6:31 [PATCH] Properly skip over quoted values Andrzej Zaborowski
2009-11-10 18:54 ` Denis Kenzior [this message]
2009-11-10 19:00 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200911101254.01405.denkenz@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox